Uh oh!
There was an error while loading. Please reload this page.
pathlib.Path.open: bring on the overloads - #4407
Merged
Merged
Conversation
hauntsaninjaforce-pushed
the
path
branch
2 times, most recently
from
August 7, 2020 04:32
16f9cdd to
afcf7b8Compare
Akuli
commented
Aug 7, 2020
Collaborator
Why are there 4 different specific binary modes ( |
JelleZijlstra
commented
Aug 7, 2020
Member
@Akuli text mode returns the same concrete type regardless of the precise mode, while binary mode returns different types. |
| def open( | ||
| self, mode: OpenBinaryMode, buffering: int, encoding: None = ..., errors: None = ..., newline: None = ..., | ||
| ) -> BinaryIO: ... | ||
| # Fallback if mode is not specified |
Member
There was a problem hiding this comment.
I'm not sure this is right in Python 2; our stub for builtins currently always return BinaryIO from Python 2's open.
CollaboratorAuthor
There was a problem hiding this comment.
Good point, check_consistent has just conditioned me to copy-paste. One day we'll be free.
hauntsaninja
commented
Aug 22, 2020
CollaboratorAuthor
gentle bump! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.