Uh oh!
There was an error while loading. Please reload this page.
Remove google/__init__.pyi - #6106
Conversation
Since google is a namespace package, it won't have an init. Depends on typeshed-internal/stub_uploader#33
JelleZijlstra
commented
Oct 4, 2021
Waiting for the mypy change might not be a good idea; it's likely going to take a while. |
nipunn1313
commented
Oct 4, 2021
I've made some progress with python/mypy#11257 , python/mypy#11259 , python/mypy#11261 . That being said - this doesn't strictly depend on it, but it will confuse everyone using protobuf stubs - since they'll have to add this
^ both of these have gotten in! |
srittau
commented
Feb 2, 2022
Is this PR viable now? |
nipunn1313
commented
Feb 2, 2022
Ideallypython/mypy#9636 gets in first. I think it is ready, though I sense some hesitancy in the thread there. Otherwise, we'll have to educate a lot of folks to pass If we think python/mypy#9636 will have a lot of delay - I can instead look into alternate ways to encourage people to set |
srittau
commented
Feb 2, 2022
Ok, lets wait for mypy 0.940, in case python/mypy#9636 goes into it. If it doesn't make 0.940 for some reason, we can merge it here first. |
hmc-cs-mdrissi
commented
Mar 20, 2022
Now that 0.940 has been released can we merge this? My interest is that the lack of this, means pyright produces a number of errors when google libraries are imported and that google stub information gets lost. At moment I've mostly just followed a practice of type ignore and let several google libraries behave like Any. |
JelleZijlstra
commented
Mar 20, 2022
I'm OK with merging this. @hauntsaninja do you think the namespace packages change will make it into mypy soon? |
Probably 🤷 I'm fine with this being merged whenever, since it's impacting users of other type checkers. |
nipunn1313
commented
Mar 21, 2022
Hi! Please revert due to #7519 ! |
This reverts commit a11a664.
Since google is a namespace package, it won't have an init.
Depends on typeshed-internal/stub_uploader#33 - so the stub uploader can handle it
Should wait until
microsoft/pyright@5e38fab gets in. See discussion
May also want to wait until python/mypy#9636 gets in - as it'll be confusing for folks to have to add the
--namespace-packagesflag to mypy for things to work.