Skip to content

add contextlib.chdir - #6191

Merged
JelleZijlstra merged 7 commits into
python:masterfrom
graingert:patch-6
Nov 8, 2021
Merged

add contextlib.chdir#6191
JelleZijlstra merged 7 commits into
python:masterfrom
graingert:patch-6

Conversation

@graingert

@graingertgraingert commented Oct 23, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

see python/cpython#28271

Is it too early to start adding 3.11 types to typeshed? I'm looking to add it here so I can backport the types cleanly into contextlib2

@graingertgraingert mentioned this pull request Oct 23, 2021
Closed
Akuli
Akuli reviewed Oct 23, 2021
View reviewed changes
Comment threadstdlib/contextlib.pyi Outdated
Comment threadstdlib/contextlib.pyi Outdated
@graingert@Akuli
Update stdlib/contextlib.pyi
ea866c2
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@Akuli

Akuli commented Oct 23, 2021

Copy link
Copy Markdown
Collaborator

It might be a bit early because 3.11 can still change, but we can always change this later. I would like to know what other maintainers think.

Akuli
Akuli reviewed Oct 23, 2021
View reviewed changes
Comment threadstdlib/contextlib.pyi Outdated
@github-actions

This comment has been minimized.

Sign in to view
@srittau

srittau commented Oct 23, 2021

Copy link
Copy Markdown
Collaborator

I'm fine with adding 3.11 annotations, especially ones that are not likely to change. Less chance to forget them later.

Akuli
Akuli reviewed Oct 23, 2021
View reviewed changes
Comment threadstdlib/contextlib.pyi Outdated
@github-actions

This comment has been minimized.

Sign in to view
@graingert@Akuli
Update stdlib/contextlib.pyi
2cbe6ec
Co-authored-by: Akuli <akuviljanen17@gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
Akuli
Akuli reviewed Oct 23, 2021
View reviewed changes
Comment threadstdlib/contextlib.pyi Outdated
JelleZijlstra
JelleZijlstra reviewed Oct 23, 2021
View reviewed changes
Comment threadstdlib/contextlib.pyi
JelleZijlstra
JelleZijlstra reviewed Oct 23, 2021
View reviewed changes
Comment threadstdlib/contextlib.pyi Outdated
@graingert@JelleZijlstra
Update stdlib/contextlib.pyi
5f103bd
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
graingert
graingert commented Nov 8, 2021
View reviewed changes
Comment threadstdlib/contextlib.pyi Outdated
@github-actions

github-actionsBot commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
JelleZijlstra merged commit 50dff24 into python:masterNov 8, 2021
@graingert
graingert deleted the patch-6 branch November 8, 2021 20:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@AkuliAkuliAkuli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@graingert@Akuli@srittau@JelleZijlstra