Skip to content

Use stubtest 0.920 - #6589

Merged
Akuli merged 37 commits into
python:masterfrom
hauntsaninja:upgrade-mypy
Dec 17, 2021
Merged

Use stubtest 0.920#6589
Akuli merged 37 commits into
python:masterfrom
hauntsaninja:upgrade-mypy

Conversation

@hauntsaninja

@hauntsaninjahauntsaninja commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

@hauntsaninja

hauntsaninja commented Dec 16, 2021•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

unittest._log seems to be unconditionally imported, so mypy's complaint on the lower Python versions looks correct. Surprised pyright doesn't complain, maybe pyright doesn't listen to submodules in VERSIONS

Looks like we've picked up some stubtest changes as well (several from the decision to follow type aliases). I'm going to mostly allowlist these.

@hauntsaninja
hauntsaninja marked this pull request as draft December 16, 2021 00:38
@hauntsaninja

hauntsaninja commented Dec 16, 2021•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

@srittau is there a good way to trigger stubtest on all third party stubs on this PR?
I just did it the dumb way for now

@AlexWaygood

AlexWaygood commented Dec 16, 2021

Copy link
Copy Markdown
Member

@srittau is there a good way to trigger stubtest on all third party stubs on this PR?
I just did it the dumb way for now

Wait, shouldn't you have done that on this PR, rather than the other PR? The other PR doesn't have mypy updated yet

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja

hauntsaninja commented Dec 16, 2021

Copy link
Copy Markdown
CollaboratorAuthor

@AlexWaygood Oooops, yes, I should! I confused myself because I wasn't sure whether to separate out actual stub changes into their own PRs. Fixing....

AlexWaygood
AlexWaygood reviewed Dec 16, 2021
View reviewed changes
Comment threadtests/stubtest_allowlists/py310.txt Outdated
@hauntsaninja@AlexWaygood
Update tests/stubtest_allowlists/py310.txt
adb5315
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
@srittau

srittau commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

Maybe it's easier to temporarily use stubtest 0.910 and do the upgrade separately.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Dec 16, 2021
@AlexWaygood
Add timeout attribute to _socket.socket
28f2d6c
Helps unblock python#6589 (new error uncovered by upgrading stubtest)
@AlexWaygoodAlexWaygood mentioned this pull request Dec 16, 2021
Merged
AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Dec 16, 2021
@AlexWaygood
Correct sre_parse.State.opengroup
7a1f958
New error picked up by updated stubtest; helps unblock python#6589
@AlexWaygoodAlexWaygood mentioned this pull request Dec 16, 2021
Merged
AlexWaygood
AlexWaygood reviewed Dec 16, 2021
View reviewed changes
Comment threadtests/stubtest_allowlists/py3_common.txt
Comment threadtests/stubtest_allowlists/py3_common.txt
@srittau

srittau commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

The only thing left in master are the stubtest fixes. Should we close this and open a new PR?

@AkuliAkuli mentioned this pull request Dec 16, 2021
Closed
srittau
srittau reviewed Dec 16, 2021
View reviewed changes
Comment thread.github/workflows/tests.yml Outdated
srittau
srittau reviewed Dec 16, 2021
View reviewed changes

@srittausrittau left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stubtest 0.920 should also be reenabled in .github/workflows/stubtest.yml.

Well, this change is already in master. :)

@hauntsaninjahauntsaninja changed the title Upgrade mypyUse stubtest 0.920Dec 16, 2021
@JelleZijlstra@srittau
Update .github/workflows/tests.yml
54a7ba8
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
@srittau

srittau commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

https://github.com/python/typeshed/actions/runs/1589196055 for a guide on what fails at the moment.

BTW: If you push your branch directly into the python/typeshed repo, we can run the "stubtest" workflow against it manually now.

@hauntsaninja

hauntsaninja commented Dec 17, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Okay, I think this should be good. Here's a GA run showing that stubtest for third party stubs also succeeds: https://github.com/python/typeshed/runs/4542782687?check_suite_focus=true

@hauntsaninja
hauntsaninja marked this pull request as ready for review December 17, 2021 07:17
Akuli
Akuli reviewed Dec 17, 2021
View reviewed changes
Comment threadtests/stubtest_allowlists/py310.txt Outdated
Akuli
Akuli reviewed Dec 17, 2021
View reviewed changes
Comment threadtests/stubtest_allowlists/py310.txt Outdated
@Akuli
Akuli merged commit 2ad00c9 into python:masterDec 17, 2021
@hauntsaninja
hauntsaninja deleted the upgrade-mypy branch December 17, 2021 19:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkuliAkuliAkuli left review comments
@AlexWaygoodAlexWaygoodAlexWaygood left review comments
@srittausrittausrittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hauntsaninja@AlexWaygood@srittau@Akuli@JelleZijlstra