Uh oh!
There was an error while loading. Please reload this page.
add (Base)ExceptionGroup - #6655
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
left a comment
There was a problem hiding this comment.
One question below, but LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
agronholm
commented
Jan 11, 2022
A couple questions:
I'm happy to submit a follow-up PR to fix these. |
JelleZijlstra
commented
Jan 11, 2022
@agronholm good catch about the I think I used |
agronholm
commented
Jan 11, 2022
The PEP doesn't really define the |
JelleZijlstra
commented
Jan 11, 2022
Yes, the summary is that you're right on both counts :) Feel free to submit a PR! |
agronholm
commented
Jan 11, 2022
Done: #6895 |
agronholm
commented
Jan 12, 2022
I noticed another issue: |
Fixes#6632