Add regex stubs by jpy-git · Pull Request #6713 · python/typeshed

jpy-git · 2021-12-27T18:38:48Z

This PR closes#6710.

Aim is to provide typing stubs for the regex package.
This regex implementation is backwards-compatible with the standard 're' module, but offers additional functionality.
Github: https://github.com/mrabarnett/mrab-regex
PyPI: https://pypi.org/project/regex/

I'm opening this as a draft as I have a couple questions about how to reference types for classes defined in C code (will annotate the PR with the questions). Any help/suggestions are greatly appreciated 😄

jpy-git

Some direction on these points (plus any general improvements) would be really appreciated, thanks! 😄

AlexWaygood

With the latest mypy release, we no longer need uppercase Tuple (and attempting to import it will cause CI to fail after the changes to check_new_syntax that I introduced in #6717 🙂)

jpy-git

This should be ready for review now 😄

LeeeeT · 2021-12-30T11:26:00Z

Thank you so much! Your PR is just in time 🚀🚀🚀

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Co-authored-by: Akuli <akuviljanen17@gmail.com>

Akuli

Thanks!

jpy-git · 2021-12-30T19:17:03Z

Awesome, thanks @Akuli and @AlexWaygood for the great reviews 😄

richardjharris · 2022-02-21T15:46:31Z

+ ) -> Scanner[AnyStr]: ...
+
+@final
+class Match(Generic[AnyStr]):


Is this missing __getitem__? After updating some modules I now get hundreds of "__getitem__" method not defined on type "Match[str]" errors.

I'm not using regex and have not investigated, but this seems likely. re.Match (or rather typing.Match) also has a __getitem__() field. Cc @jpy-git

Makes sense, will make a PR 👍

jpy-git added 2 commits December 27, 2021 16:32

Add initial regex stubs
9207bcb

Remove stubgen comments
76656d4

jpy-git commented Dec 27, 2021
View reviewed changes

Comment threadstubs/regex/regex/_regex.pyi Outdated
Comment threadstubs/regex/regex/regex.pyi Outdated
Comment threadstubs/regex/regex/regex.pyi Outdated

Remove unused import
4b43f7d

srittau reviewed Dec 28, 2021
View reviewed changes

Comment threadstubs/regex/regex/regex.pyi Outdated

AlexWaygood reviewed Dec 28, 2021
View reviewed changes

Comment threadstubs/regex/regex/regex.pyi Outdated
Comment threadstubs/regex/regex/regex.pyi Outdated
Comment threadstubs/regex/regex/regex.pyi Outdated

jpy-git added 5 commits December 28, 2021 22:07

Add C module classes
6f7a6cf

Use type alias for Pattern and Match
15f4fec

Use frozenset over Frozenset
7d3bbf3

Add error and Scanner
8284e84

Add error and Scanner
1be94ad

jpy-git changed the title ~~Add initial regex stubs~~Add regex stubsDec 29, 2021

jpy-git commented Dec 29, 2021
View reviewed changes

Comment threadstubs/regex/@tests/stubtest_allowlist.txt
Comment threadstubs/regex/regex/_regex_core.pyi Outdated
Comment threadstubs/regex/regex/regex.pyi Outdated
Comment threadstubs/regex/regex/_regex.pyi Outdated

jpy-git marked this pull request as ready for review December 29, 2021 01:40

use list[Any] instead of union return
5ddc098

AlexWaygood reviewed Dec 30, 2021
View reviewed changes

Comment threadstubs/regex/regex/regex.pyi Outdated
Comment threadstubs/regex/regex/regex.pyi Outdated

jpy-gitand others added 2 commits December 30, 2021 13:21

Update stubs/regex/regex/regex.pyi
fca60fb
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Remove unnecessary overrides
7944312

Akuli reviewed Dec 30, 2021
View reviewed changes

Comment threadstubs/regex/regex/_regex.pyi Outdated
Comment threadstubs/regex/regex/_regex.pyi Outdated
Comment threadstubs/regex/regex/regex.pyi

jpy-git added 4 commits December 30, 2021 13:37

Use Mapping over dict
021ca84

Remove undocumented Scanner class and use _typeshed.Self
0453e3c

Add stubtest comment
5ce5e17

Align returns with re
1961df1

Akuli reviewed Dec 30, 2021
View reviewed changes

Comment threadstubs/regex/@tests/stubtest_allowlist.txt Outdated
Comment threadstubs/regex/regex/_regex.pyi
Comment threadstubs/regex/regex/_regex.pyi
Comment threadstubs/regex/regex/_regex.pyi
Comment threadstubs/regex/regex/regex.pyi Outdated

jpy-git mentioned this pull request Dec 30, 2021
Remove unnecessary overloads from re #6762
Closed

jpy-gitand others added 3 commits December 30, 2021 18:44

Update stubs/regex/@tests/stubtest_allowlist.txt
dad0a1f
Co-authored-by: Akuli <akuviljanen17@gmail.com>

Implement review feedback
c7e64ae

Use typing_extensions for Literal and final
eb84b36

Akuli approved these changes Dec 30, 2021
View reviewed changes

Akuli merged commit fbf5982 into python:masterDec 30, 2021

jpy-git deleted the regex_stubs branch December 30, 2021 19:17

This was referenced Dec 30, 2021
Add types-regex package for type checking sqlfluff/sqlfluff#2216
Merged
Type-checking difference between re and regex modules mrabarnett/mrab-regex#423
Open

richardjharris reviewed Feb 21, 2022
View reviewed changes

jpy-git mentioned this pull request Feb 23, 2022
regex stubs: Add __getitem__ method to Match #7372
Merged

coderabbitaiBot mentioned this pull request Apr 24, 2026
Claude/mirror spanish module architecture c ui6 z cicero-im/lexpredict-lexnlp#19
Merged

Uh oh!

Uh oh!

Conversation

jpy-git commented Dec 27, 2021

Uh oh!

jpy-git left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpy-git left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LeeeeT commented Dec 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Akuli left a comment

Choose a reason for hiding this comment

Uh oh!

jpy-git commented Dec 30, 2021

Uh oh!

richardjharrisFeb 21, 2022

Choose a reason for hiding this comment

Uh oh!

srittauFeb 21, 2022

Choose a reason for hiding this comment

Uh oh!

jpy-gitFeb 23, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants