Not all constants in fcntl are available on macos

[sobolevn]

Let's try this combination

[AlexWaygood]

IIRC (please check), if sys.platform == "linux" means (bizarrely) "only present on Ubuntu". I think if you want to say "only present on [grab-bag of miscellaneous linux systems]", you need to say if sys.platform != "win32" and sys.platform != "darwin"

[sobolevn]

Maybe we should add some extra OS to the test? We can't do that natively, but I can add some docker-container tests 🤔

I will add an issue for that.

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[Akuli]

IIRC (please check), if sys.platform == "linux" means (bizarrely) "only present on Ubuntu".

This isn't correct. if sys.platform == "linux" is the correct check for "only present on Ubuntu", and also "present on all linux distros". A check like if sys.platform != "win32" and sys.platform != "darwin" will also be true on other posix systems than linux and macos, such as BSD and Solaris, so it isn't the right choice for linux-specific things.

[AlexWaygood]

IIRC (please check), if sys.platform == "linux" means (bizarrely) "only present on Ubuntu".

This isn't correct. if sys.platform == "linux" is the correct check for "only present on Ubuntu", and also "present on all linux distros". A check like if sys.platform != "win32" and sys.platform != "darwin" will also be true on other posix systems than linux and macos, such as BSD and Solaris, so it isn't the right choice for linux-specific things.

Thanks for the correction!

[srittau]

I didn't double check in depth, but LGTM.