Skip to content

Update importlib.metadata typings for 3.10 - #7331

Merged
JelleZijlstra merged 19 commits into
python:masterfrom
itaisteinherz:feature/importlib-metadata-updates
Feb 25, 2022
Merged

Update importlib.metadata typings for 3.10#7331
JelleZijlstra merged 19 commits into
python:masterfrom
itaisteinherz:feature/importlib-metadata-updates

Conversation

@itaisteinherz

Copy link
Copy Markdown
Contributor

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@itaisteinherz

itaisteinherz commented Feb 20, 2022

Copy link
Copy Markdown
ContributorAuthor

At first I thought that I'll need to add EntryPoints as well, but after another look it seems like it isn't used by any public method.

Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
@itaisteinherz

Copy link
Copy Markdown
ContributorAuthor

At first I thought that I'll need to add EntryPoints as well, but after another look it seems like it isn't used by any public method.

It seems like EntryPoints will be required for the typing of SelectableGroups.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment threadstdlib/importlib/metadata/__init__.pyi Outdated
Comment threadstdlib/importlib/metadata/__init__.pyi
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittausrittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing I noticed, looks good to me otherwise.

Comment threadstdlib/importlib/metadata/__init__.pyi
@itaisteinherzitaisteinherz changed the title Update importlib_metadata typings for 3.10Update importlib.metadata typings for 3.10Feb 24, 2022
@JelleZijlstra
JelleZijlstra merged commit f4b43da into python:masterFeb 25, 2022
@itaisteinherz
itaisteinherz deleted the feature/importlib-metadata-updates branch February 25, 2022 08:27
@itaisteinherz

itaisteinherz commented Feb 25, 2022

Copy link
Copy Markdown
ContributorAuthor

@AlexWaygood should I have also added SelectableGroups and EntryPoints to __all__? I just noticed your PR #7326, which initially added __all__, and noticed I forgot to add them.
(I also noticed that you didn't include EntryPoint in __all__?)

@AlexWaygood

AlexWaygood commented Feb 25, 2022

Copy link
Copy Markdown
Member

@AlexWaygood should I have also added SelectableGroups and EntryPoints to __all__? I just noticed your PR #7326, which initially added __all__, and noticed I forgot to add them. (I also noticed that you didn't include EntryPoint in __all__?)

@itaisteinherz, none of them are included in __all__ at runtime, so I don't see any reason to include them in __all__ in the stub :) https://github.com/python/cpython/blob/2c228a7b8f89e9ed8d390370abd771d4993b79d8/Lib/importlib/metadata/__init__.py#L30

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stub for importlib.metadata on Python 3.10 is incomplete

7 participants

@itaisteinherz@AlexWaygood@srittau@JelleZijlstra@hauntsaninja@Molkree@Akuli