Skip to content

Add __all__ for asyncio.unix_events & asyncio.taskgroups, and simplify asyncio.__init__ - #7343

Merged
srittau merged 4 commits into
python:masterfrom
AlexWaygood:asyncio
Feb 28, 2022
Merged

Add __all__ for asyncio.unix_events & asyncio.taskgroups, and simplify asyncio.__init__#7343
srittau merged 4 commits into
python:masterfrom
AlexWaygood:asyncio

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Feb 21, 2022

Copy link
Copy Markdown
Member

Now that all asyncio submodules have accurate __all__s, we can drastically simplify the imports in asyncio.__init__.pyi and do something much more similar to what's done at runtime.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygoodAlexWaygood changed the title Simplify asyncio.__init__Add __all__ for aysncio.unix_events & asyncio.taskgroups, & simplify asyncio.__init__Feb 21, 2022
@AlexWaygoodAlexWaygood changed the title Add __all__ for aysncio.unix_events & asyncio.taskgroups, & simplify asyncio.__init__Add __all__ for aysncio.unix_events & asyncio.taskgroups, and simplify asyncio.__init__Feb 21, 2022
@AlexWaygood

AlexWaygood commented Feb 21, 2022

Copy link
Copy Markdown
MemberAuthor

@rchen152, any idea what the pytype error is trying to tell me? 🙂

@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygoodAlexWaygood changed the title Add __all__ for aysncio.unix_events & asyncio.taskgroups, and simplify asyncio.__init__Add __all__ for asyncio.unix_events & asyncio.taskgroups, and simplify asyncio.__init__Feb 21, 2022
@rchen152

rchen152 commented Feb 22, 2022

Copy link
Copy Markdown
Collaborator

Looks like pytype is either not allowing __all__ to be imported multiple times or complaining about it being defined multiple times in the same file (despite the version guards). Either way, looks like a pytype bug to me =/ Investigating.

@AlexWaygood

AlexWaygood commented Feb 22, 2022

Copy link
Copy Markdown
MemberAuthor

Investigating.

Thank you!!

rchen152 added a commit to google/pytype that referenced this pull request Feb 23, 2022
@rchen152
Ignore some private attributes when doing pyi star imports.
61056f0
* __all__ should always be skipped.
* Underscore-prefixed TypeVar definitions are obviously not meant to be
exported.
See python/typeshed#7343.
PiperOrigin-RevId: 430327362
@rchen152

rchen152 commented Feb 23, 2022

Copy link
Copy Markdown
Collaborator

I've submitted a fix for this; as long as I don't run into any unexpected problems, I should be able to cut a pytype release containing the fix tomorrow or Thursday.

@rchen152

rchen152 commented Feb 24, 2022

Copy link
Copy Markdown
Collaborator

Alright, pytype-2022.2.23 is out. Let me know if you run into any problems.

AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Feb 24, 2022
@AlexWaygood
Upgrade pytype to 22.2.23
7f5dc64
Unblocks python#7343
@AlexWaygoodAlexWaygood mentioned this pull request Feb 24, 2022
Merged
JelleZijlstra pushed a commit that referenced this pull request Feb 24, 2022
@AlexWaygood
Upgrade pytype to 22.2.23 (#7375)
062fc75
Unblocks #7343
@AlexWaygood

AlexWaygood commented Feb 24, 2022

Copy link
Copy Markdown
MemberAuthor

Alright, pytype-2022.2.23 is out. Let me know if you run into any problems.

Looks like it's working great — thanks for the quick fix!

@github-actions

github-actionsBot commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

core (https://github.com/home-assistant/core)
+ homeassistant/runner.py:51: error: Unused "type: ignore[misc, valid-type]" comment+ homeassistant/runner.py:62: error: "HassEventLoopPolicy" has no attribute "_loop_factory" [attr-defined]

@AlexWaygood

AlexWaygood commented Feb 28, 2022

Copy link
Copy Markdown
MemberAuthor

Ping on this -- the CI is green now that the pytype version used in CI has been updated :)

srittau
srittau approved these changes Feb 28, 2022
View reviewed changes

@srittausrittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm a tad worried about the second line in the primer output, this can be sorted out later if necessary.

@srittau
srittau merged commit bf167d4 into python:masterFeb 28, 2022
@AlexWaygood
AlexWaygood deleted the asyncio branch February 28, 2022 11:53
@AlexWaygoodAlexWaygood mentioned this pull request Mar 1, 2022
Merged
This was referenced Mar 7, 2022
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittausrittausrittau approved these changes
@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninja

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlexWaygood@rchen152@srittau@hauntsaninja@JelleZijlstra