Upgrade pyright, improve pyright config files by AlexWaygood · Pull Request #8072 · python/typeshed

AlexWaygood · 2022-06-14T12:00:46Z

Upgrade pyright
Improve comments in the config files
Use the 3.10 workflow instead of the 3.9 workflow for the "check annotations" comments
Enable several settings that aren't currently enabled

Fixes#7928; fixes#6905.

…o pyright

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

…o pyright

AlexWaygood · 2022-06-16T16:20:44Z

 _weakref.CallableProxyType.__getattr__ # Should have all attributes of proxy
 _weakref.ProxyType.__getattr__ # Should have all attributes of proxy
 _weakref.ReferenceType.__call__ # C function default annotation is wrong
+_weakref.ReferenceType.__init__ # Runtime defines __new__ but stubtest thinks __init__ is also defined.


This is a guess. But if I'm not correct here, I think the best thing to do here is to have a white lie in the stub anyway.

AlexWaygood · 2022-06-16T16:21:03Z

This should now be ready for review :)

srittau

One minor suggestion, LGTM otherwise.

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>

github-actions · 2022-06-16T17:47:46Z

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AlexWaygoodand others added 6 commits June 14, 2022 12:54

Beef up pyright config
1695d6a

Merge branch 'master' into pyright
99be1e6

Merge remote-tracking branch 'origin/master' into pyright
dfb48bd

Merge branch 'master' into pyright
91b9fa5

Add ignores for unfixable things
2b208cb

Merge branch 'pyright' ofhttps://github.com/AlexWaygood/typeshedint…
c3839ce
…o pyright

AlexWaygood commented Jun 14, 2022
View reviewed changes

Comment threadstdlib/subprocess.pyi Outdated

Update stdlib/subprocess.pyi
8414ae4

JelleZijlstra reviewed Jun 14, 2022
View reviewed changes

Comment threadpyrightconfig.stricter.json Outdated

This comment has been minimized.
Sign in to view

Update pyrightconfig.stricter.json
4dd0069
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

This comment has been minimized.
Sign in to view

AlexWaygood added 3 commits June 14, 2022 17:33

Change two __init__ methods to __new__ methods
1ed0f95

Merge branch 'pyright' ofhttps://github.com/AlexWaygood/typeshedint…
879d274
…o pyright

Allowlists etc.
968e91d

This comment has been minimized.
Sign in to view

AlexWaygood commented Jun 14, 2022
View reviewed changes

Comment threadpyrightconfig.json Outdated

AlexWaygoodand others added 3 commits June 14, 2022 17:43

Update pyrightconfig.json
7db0f00

More allowlist shenanigans
3567494

Merge branch 'pyright' ofhttps://github.com/AlexWaygood/typeshedint…
7feccdf
…o pyright

This comment has been minimized.
Sign in to view

stubtest
7c74d5a

This comment has been minimized.
Sign in to view

Merge branch 'master' into pyright
2297de2

This comment has been minimized.
Sign in to view

AlexWaygoodand others added 2 commits June 16, 2022 15:30

Fix a constructor in SQLAlchemy
b81c85c

Merge branch 'master' into pyright
067e087

Merge branch 'pyright' ofhttps://github.com/AlexWaygood/typeshedint…
da1f2a1
…o pyright

This comment has been minimized.
Sign in to view

AlexWaygood added 2 commits June 16, 2022 17:02

White lies in SQLAlchemy
b9c5197

Allow
2b5e5ed

AlexWaygood commented Jun 16, 2022
View reviewed changes

Comment threadstubs/SQLAlchemy/@tests/stubtest_allowlist.txt Outdated

Update stubs/SQLAlchemy/@tests/stubtest_allowlist.txt
86edde9

AlexWaygood marked this pull request as ready for review June 16, 2022 16:12

This comment has been minimized.
Sign in to view

AlexWaygood commented Jun 16, 2022
View reviewed changes

srittau approved these changes Jun 16, 2022
View reviewed changes

Comment threadstdlib/abc.pyi Outdated

AlexWaygoodand others added 2 commits June 16, 2022 18:34

Update stdlib/abc.pyi
6b11e9c
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>

[pre-commit.ci] auto fixes from pre-commit.com hooks
463bee3

AlexWaygood commented Jun 16, 2022
View reviewed changes

Comment threadstdlib/abc.pyi Outdated

Undo the damage done by pre-commit
e014952

This comment has been minimized.
Sign in to view

AlexWaygood merged commit 6b0c8df into python:masterJun 16, 2022

AlexWaygood deleted the pyright branch June 16, 2022 17:50

Uh oh!

Uh oh!

Conversation

AlexWaygood commented Jun 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AlexWaygoodJun 16, 2022

Choose a reason for hiding this comment

Uh oh!

AlexWaygood commented Jun 16, 2022

Uh oh!

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actionsBot commented Jun 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AlexWaygood commented Jun 14, 2022•
edited
Loading