Type http.client.HTTPConnection.sock

[sobolevn]

It can be either:

• None: https://github.com/python/cpython/blob/310f94871a923f6cf3dc9259e732ce2376578b26/Lib/http/client.py#L856
• or socket.socket: https://github.com/python/cpython/blob/310f94871a923f6cf3dc9259e732ce2376578b26/Lib/http/client.py#L955-L956

[sobolevn]

Oh, I see. Looks like the idea behind Any here is that different subtypes can use different sock types. What's is the policy in this case?

Do we fallback to Any or do we require # type: ignore[override] for such cases?

[AlexWaygood]

This looks quite disruptive, and in practice, users can probably be confident that sock will be a socket object after .connect() has been called.

Maybe try sock: socket | Any instead, with a comment explaining that it could be None if connect() has not yet been called?

[Akuli]

Please add something like sock: SSLSocket | Any into HTTPSConnection. HTTPS connections never use unencrypted socket.sockets.

[sobolevn]

Sure! Source: https://github.com/python/cpython/blob/310f94871a923f6cf3dc9259e732ce2376578b26/Lib/http/client.py#L1456-L1457

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

urllib3 (https://github.com/urllib3/urllib3)
+ test/with_dummyserver/test_https.py:463: error: Item "socket" of "Union[socket, Any]" has no attribute "server_hostname" [union-attr]+ test/with_dummyserver/test_https.py:784: error: Item "socket" of "Union[socket, Any]" has no attribute "version" [union-attr]+ test/with_dummyserver/test_https.py:882: error: Item "socket" of "Union[socket, Any]" has no attribute "version" [union-attr]