refactor: expand types in xml module

[kkirsche]

1. encoding changed from Any | None to str | None as it's used as a parameter to TextIOWrapper
   • https://github.com/python/cpython/blob/main/Lib/xml/dom/minidom.py#L54
2. standalone changed from Any | None to bool | None per https://docs.python.org/3/library/xml.dom.minidom.html#xml.dom.minidom.Node.writexml
3. localName changed from Any | None to str | None as Node's localName property returns str | None
4. Comparison operators set to object as they use id to do the comparisons, not object specific behavior: https://github.com/python/cpython/blob/main/Lib/xml/dom/minidom.py#L534
5. TypeInfo partially typed based on https://cs.github.com/python/cpython/blob/5ed584cb6b4e544d307f2f1b6f28667078cc20af/Lib/xml/dom/expatbuilder.py?q=repo%3Apython%2Fcpython+path%3ALib%2Fxml%2F+TypeInfo#L47-L58
6. get*Item check with a try / except: https://github.com/python/cpython/blob/main/Lib/xml/dom/minidom.py#L571
7. Various create methods include isinstance type checking to force behaviors: https://github.com/python/cpython/blob/main/Lib/xml/dom/minidom.py#L1676

[kkirsche]

Also, some of the parameter names of node are misleading, as the isinstance checks are checking for Attr nodes specifically, which is deceptive on a first pass:
https://github.com/python/cpython/blob/main/Lib/xml/dom/minidom.py#L607-L608

[JelleZijlstra]

Thanks, I have a few comments.

[JelleZijlstra]

The localName argument is actually ignored: https://github.com/python/cpython/blob/18b1782192f85bd26db89f5bc850f8bee4247c1a/Lib/xml/dom/minidom.py#L355.

Seems like it wants a if localName is not None: self._localName = localName. Are you interested in contributing that to CPython?

[kkirsche]

Sure, I'm happy to give that a shot.

Issue:
python/cpython#96175

PR:
python/cpython#96176

[JelleZijlstra]

My comments were addressed, thanks. Still need to resolve @AlexWaygood's concern.

[AlexWaygood]

I haven't reviewed in detail, but my concerns have been addressed, and I'll defer to @JelleZijlstra on the rest! :)

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉