Uh oh!
There was an error while loading. Please reload this page.
Fix protobuf stubtest errors - #8758
Conversation
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
commented
Sep 17, 2022
The only difference between the runs I see is that the first has iflen(args.dists) ==0:
dists=sorted((typeshed_dir/"stubs").iterdir())
...
fori, distinenumerate(dists):
ifi%args.num_shards!=args.shard_index:
continueSo we have added a project whose name starts with a letter before |
AlexWaygood
commented
Sep 17, 2022
A difference in how the daily test is being run would also be insufficient to explain the differences we're seeing in CI. We also need to explain the fact that stubtest passed on the PR run both in #8735 and in this PR. While we could speculate that there might be a bug in the script that somehow leads to different packages interfering with each other in the daily test, those concerns don't apply for stubtest in PR runs -- we can be confident that the package is being tested in a fairly isolated environment in a PR run. |
hauntsaninja
commented
Sep 19, 2022
Merging in case that makes the daily test stops failing. Note that we can use |
JelleZijlstra
commented
Sep 21, 2022
At runtime |
Fixes#8745.
I'm a little confused, as this PR is basically a revert of #8735. Stubtest appears to have run with the same environment for the two runs, so I'm not sure why the results are different:
We've had the same stubtest errors two nights in a row, however.