Skip to content

Add type stubs for package console-menu. - #8820

Merged
JelleZijlstra merged 18 commits into
python:masterfrom
bastisawesome:master
Oct 3, 2022
Merged

Add type stubs for package console-menu.#8820
JelleZijlstra merged 18 commits into
python:masterfrom
bastisawesome:master

Conversation

@bastisawesome

@bastisawesomebastisawesome commented Oct 1, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
JelleZijlstra
JelleZijlstra requested changes Oct 2, 2022
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a number of small comments.

Comment threadstubs/console-menu/consolemenu/console_menu.pyi Outdated
Comment threadstubs/console-menu/consolemenu/console_menu.pyi Outdated
Comment threadstubs/console-menu/consolemenu/console_menu.pyi Outdated
Comment threadstubs/console-menu/consolemenu/console_menu.pyi Outdated
Comment threadstubs/console-menu/consolemenu/console_menu.pyi Outdated
Comment threadstubs/console-menu/consolemenu/prompt_utils.pyi Outdated
Comment threadstubs/console-menu/consolemenu/prompt_utils.pyi Outdated
Comment threadstubs/console-menu/consolemenu/screen.pyi Outdated
Comment threadstubs/console-menu/consolemenu/selection_menu.pyi Outdated
Comment threadstubs/console-menu/consolemenu/selection_menu.pyi Outdated
bastisawesomeand others added 10 commits October 2, 2022 08:16
@bastisawesome
Merge branch 'python:master' into master
99c79d9
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/console_menu.pyi
6ba1038
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/console_menu.pyi
9d9e9f5
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/console_menu.pyi
5d78ecf
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/console_menu.pyi
66428d3
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/format/menu_borders.pyi
f51cc31
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/format/menu_borders.pyi
8be7aad
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/items/external_item.pyi
138fa50
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bastisawesome@JelleZijlstra
Update stubs/console-menu/consolemenu/items/function_item.pyi
946474d
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
18c345c
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@bastisawesome@JelleZijlstra
Apply suggestions from code review
c14000a
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
6 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Oct 2, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JelleZijlstra
JelleZijlstra approved these changes Oct 3, 2022
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JelleZijlstra
JelleZijlstra merged commit aab29f6 into python:masterOct 3, 2022
@AlexWaygoodAlexWaygood mentioned this pull request Dec 8, 2022
Merged
hauntsaninja pushed a commit to python/mypy that referenced this pull request Dec 20, 2022
@AlexWaygood
Updatestubinfo.pyfor recent typeshed changes (#14265)
fcd705d
Removals from `stubinfo.py`:
- `atomicwrites` is archived and deprecated at runtime; stubs were
removed from typeshed in python/typeshed#8925
- `attrs` has had inline types for a very long time now
- `chardet` recently cut a release with inline types; typeshed's stubs
were marked obsolete in python/typeshed#9318
- `cryptography` has had inline types for a very long time now; the only
reason why it's still in typeshed is because other typeshed packages
need `types-cryptography` as a dependency, and our testing
infrastructure therefore can't currently cope with it being removed from
typeshed.
- `emoji` recently cut a release bundling stubs with the runtime
package; typeshed's stubs were marked obsolete in
python/typeshed#9051
- `termcolor` recently cut a release with inline types; typeshed's stubs
were marked obsolete in python/typeshed#8746
- `prettytable` recently cut a release with inline types; typeshed's
stubs were marked obsolete in
python/typeshed#9023
Additions:
- Stubs for `Xlib` were added in
python/typeshed#9279
- Stubs for `consolemenu` were added in
python/typeshed#8820
- Stubs for `dockerfile_parse` were added in
python/typeshed#9305
- Stubs for `flask_migrate` were added in
python/typeshed#8967
- Stubs for `paho.mqtt` were added in
python/typeshed#8853
- Stubs for `pycocotools` were added in
python/typeshed#9086
- Stubs for many `pywin32` modules were added in
python/typeshed#8825, and multiple follow-up PRs
- Stubs for `pyscreeze` were added in
python/typeshed#8823
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkuliAkuliAkuli left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bastisawesome@JelleZijlstra@Akuli