Skip to content

socketserver: improve bytes handling - #9096

Merged
AlexWaygood merged 14 commits into
python:mainfrom
JelleZijlstra:socketserver
Jan 12, 2023
Merged

socketserver: improve bytes handling#9096
AlexWaygood merged 14 commits into
python:mainfrom
JelleZijlstra:socketserver

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Nov 5, 2022

Copy link
Copy Markdown
Member

No description provided.

@JelleZijlstraJelleZijlstra mentioned this pull request Nov 5, 2022
Open
@github-actions

This comment has been minimized.

Sign in to view
@JelleZijlstra

JelleZijlstra commented Nov 5, 2022

Copy link
Copy Markdown
MemberAuthor

hm, since these are mostly for subclasses, making the address types precise is probably mostly a hassle for subclassers.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood requested changes Nov 25, 2022
View reviewed changes
Comment threadstdlib/socketserver.pyi Outdated
Comment threadstdlib/socketserver.pyi
Comment threadstdlib/socketserver.pyi
Comment threadstdlib/socketserver.pyi
Comment threadstdlib/socketserver.pyi
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Jan 12, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just one more question: Should the BaseServer.server_address attribute (on line 39) also be changed to be _socket._Address, to match the type passed in __init__?

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
AlexWaygood merged commit f64807a into python:mainJan 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra@AlexWaygood