Complete stubs for `bleach` by sobolevn · Pull Request #9314 · python/typeshed

sobolevn · 2022-12-01T18:15:51Z

bleach source: https://github.com/mozilla/bleach
html5lib source: https://github.com/html5lib/html5lib-python

AlexWaygood

A partial review. I haven't looked at linkifier.pyi or the following files yet.

AlexWaygood

Part two of my review!

AlexWaygood · 2023-02-19T13:28:14Z

@sobolevn, I've just merged in main and fixed some followup issues post-merge. Are you interested in taking a look at my review, and the remaining CI errors? :)

JelleZijlstra · 2024-02-17T23:16:25Z

@Avasam are you still up for updating this PR? Looks like it's pretty close but there's a few CI problems to fix.

Avasam · 2024-02-17T23:30:35Z

@JelleZijlstra Yes I am, since we haven't heard back from sobolevn on this. I'll take a look at it in the coming days.

…leach

AlexWaygood

I haven't done an extensive re-review, but this all looks good to me except for one comment about a comment

AlexWaygood · 2024-02-20T21:07:10Z

Thanks so much for finishing this off @Avasam!

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

github-actions · 2024-02-21T19:47:31Z

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Mark bleach as complete
4375fb5

This comment has been minimized.
Sign in to view

Fix CI
49d8286

sobolevn force-pushed the mark-bleach branch from 1f5fdcb to 49d8286Compare December 1, 2022 18:46

[pre-commit.ci] auto fixes from pre-commit.com hooks
b924759

This comment has been minimized.
Sign in to view

AlexWaygood reviewed Dec 2, 2022
View reviewed changes

AlexWaygood reviewed Dec 5, 2022
View reviewed changes

Comment threadstubs/bleach/bleach/linkifier.pyi Outdated
Comment threadstubs/bleach/bleach/linkifier.pyi Outdated
Comment threadstubs/bleach/bleach/linkifier.pyi Outdated
Comment threadstubs/bleach/bleach/sanitizer.pyi Outdated
Comment threadstubs/html5lib/html5lib/_inputstream.pyi Outdated

Avasam mentioned this pull request Jan 14, 2023
Update comments post #5768 #9527
Merged

AlexWaygoodand others added 3 commits February 19, 2023 13:59

Merge branch 'main' into mark-bleach
146a810

[pre-commit.ci] auto fixes from pre-commit.com hooks
18e31e5

Fix some obvious merge issues
24e2ad3

This comment has been minimized.
Sign in to view

AlexWaygood added 2 commits February 19, 2023 13:15

fix more mistakes when merging main
1b526fe

Update linkifier.pyi
198f6a6

AlexWaygood reviewed Feb 19, 2023
View reviewed changes

Comment threadstubs/bleach/@tests/stubtest_allowlist.txt Outdated

Remove unused allowlist entries
22fd76e

This comment has been minimized.
Sign in to view

Merge branch 'main' into mark-bleach
dc39112

This comment has been minimized.
Sign in to view

Merge branch 'main' into mark-bleach
3245722

AlexWaygood reviewed Jul 22, 2023
View reviewed changes

Comment threadstubs/bleach/METADATA.toml Outdated

Update stubs/bleach/METADATA.toml
c4767d5

AlexWaygood reviewed Jul 22, 2023
View reviewed changes

Comment threadstubs/bleach/bleach/html5lib_shim.pyi Outdated

Update stubs/bleach/bleach/html5lib_shim.pyi
704cb27

This comment has been minimized.
Sign in to view

AlexWaygood reviewed Jul 22, 2023
View reviewed changes

Comment threadstubs/bleach/bleach/html5lib_shim.pyi Outdated

fix mypy
5950664

This comment has been minimized.
Sign in to view

Merge branch 'main' into mark-bleach
7b72eef

This comment has been minimized.
Sign in to view

Avasam added 4 commits February 20, 2024 10:07

Merge branch 'main' ofhttps://github.com/python/typeshedinto mark-b…
96fc2c4
…leach

Ran stubdefaulter
c79dca1

Complete missing types
7723b65

Address PR comments
ea95d05

AlexWaygood reviewed Feb 20, 2024
View reviewed changes

Comment threadstubs/bleach/bleach/html5lib_shim.pyi

This comment has been minimized.
Sign in to view

Avasam added 2 commits February 20, 2024 13:38

More PR comments
a4ee82c

Mark uppercase names as Final
5a39614

This comment has been minimized.
Sign in to view

AlexWaygood approved these changes Feb 20, 2024
View reviewed changes

Comment threadstubs/bleach/@tests/stubtest_allowlist.txt Outdated

Reduce allowlist entried and indicate possible runtime failure
3f865d3

Avasam reviewed Feb 21, 2024
View reviewed changes

Comment threadstubs/bleach/@tests/stubtest_allowlist.txt

This comment has been minimized.
Sign in to view

typo
5f48c83

This comment has been minimized.
Sign in to view

AlexWaygood reviewed Feb 21, 2024
View reviewed changes

Comment threadstubs/html5lib/html5lib/_inputstream.pyi Outdated

Update stubs/html5lib/html5lib/_inputstream.pyi
9c88154
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

This comment has been minimized.
Sign in to view

AlexWaygood approved these changes Feb 21, 2024
View reviewed changes

Avasam reviewed Feb 21, 2024
View reviewed changes

Comment threadstubs/bleach/bleach/html5lib_shim.pyi Outdated

Avasamand others added 2 commits February 21, 2024 14:39

Update stubs/bleach/bleach/html5lib_shim.pyi
e318888

[pre-commit.ci] auto fixes from pre-commit.com hooks
c4aeaa5

AlexWaygood changed the title ~~Mark bleach as complete~~Complete stubs for bleachFeb 21, 2024

AlexWaygood merged commit a209500 into python:mainFeb 21, 2024

Uh oh!

Uh oh!

Conversation

sobolevn commented Dec 1, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

AlexWaygood commented Feb 19, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

JelleZijlstra commented Feb 17, 2024

Uh oh!

Avasam commented Feb 17, 2024

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

AlexWaygood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexWaygood commented Feb 20, 2024

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

Uh oh!

github-actionsBot commented Feb 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AlexWaygood left a comment •
edited
Loading