Support external-dependencies in pyright by Avasam · Pull Request #9434 · python/typeshed

Avasam · 2022-12-31T18:21:54Z

Extracted from #9374
Work towards #5768

Support external (non-type) dependencies in pyright in the CI.
This also adds a new reusable script that can be run from CLI to get a list of dependencies (similar to get_packages.py) and leverages the read_dependencies method added in #9382

AlexWaygood

Thanks! A few nits:

- Install all from requirements-tests.txt - lock pyright to specific version - deduplicate dependencies from script - remove extra space

AlexWaygood · 2023-01-01T00:21:27Z

Presumably pyright_test.py won't work unless contributors have already run tests/get_external_dependencies.py in their venv first. Maybe we should add a note to that effect in tests/README.md and/or the docstring for pyright_test.py?

AlexWaygood · 2023-01-01T00:24:51Z

Happy new year from the UK, by the way! 😀 🎆

…com/Avasam/typeshed into support-non-type-dependency-pyright

AlexWaygood

We're getting there! A few more comments below.

As well as these comments: I'm slightly concerned that the name of the new script (get_external_dependencies.py) is quite similar to the existing script get_packages.py. Can we disambiguate them somehow? Maybe we should rename get_packages.py, since that one has quite a vague name currently?

Avasam · 2023-01-01T20:47:18Z

[...] I'm slightly concerned that the name of the new script (get_external_dependencies.py) is quite similar to the existing script get_packages.py. Can we disambiguate them somehow? Maybe we should rename get_packages.py, since that one has quite a vague name currently?

How about something like get_system_packages and get_external_[python]_requirements ? Name is a bit long, but tab-completion is also a thing for CLI.

AlexWaygood · 2023-01-01T20:51:01Z

How about something like get_system_packages and get_external_[python]_requirements ? Name is a bit long, but tab-completion is also a thing for CLI.

Yeah, those sound great to me! 👍

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood · 2023-01-01T20:56:02Z

Actually, maybe something like get_stubtest_system_requirements.py and get_external_stub_requirements.py? That might clarify that the first script doesn't install requirements of the stubs package, it just installs requirements stubtest needs, in contrast to the second script.

What do you think?

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood

LGTM, other than the issue about the names of the files themselves :)

Avasam · 2023-01-02T23:59:55Z

Actually, maybe something like get_stubtest_system_requirements.py and get_external_stub_requirements.py? That might clarify that the first script doesn't install requirements of the stubs package, it just installs requirements stubtest needs, in contrast to the second script.
What do you think?

SGTM. I also fixed-up a comment.

AlexWaygood · 2023-01-03T22:08:55Z

(Sorry for the noise, just doing some final testing!)

This reverts commit b5a2495.

AlexWaygood

Looks great! Will merge once CI passes. Thanks for working on this!

Avasam added 6 commits December 31, 2022 13:18

Support external-dependencies in pyright
2096d1e

Conditional install
a2c3bfd

install tools first
66b8552

Fallback to lru_cache
0682f43

install typing_extensions
0a81784

pathspec + packaging
1c05a35

JelleZijlstra reviewed Dec 31, 2022
View reviewed changes

Comment thread.github/workflows/tests.yml Outdated

AlexWaygood reviewed Dec 31, 2022
View reviewed changes

Comment thread.github/workflows/tests.yml Outdated
Comment thread.github/workflows/tests.yml Outdated
Comment threadtests/get_external_dependencies.py Outdated
Comment threadtests/get_packages.py Outdated

Fix pyright dep installs
a7315e8
- Install all from requirements-tests.txt - lock pyright to specific version - deduplicate dependencies from script - remove extra space

Avasam requested review from AlexWaygood and JelleZijlstra and removed request for AlexWaygood December 31, 2022 19:57

Revert lru_cache shim
dd9a512

AlexWaygood reviewed Dec 31, 2022
View reviewed changes

Comment threadtests/get_external_dependencies.py Outdated
Comment threadtests/utils.py Outdated

Avasamand others added 2 commits December 31, 2022 17:25

Correctly de-duplicate requirements
557f871

Merge branch 'main' into support-non-type-dependency-pyright
fc61899

Avasam commented Dec 31, 2022
View reviewed changes

Comment threadtests/utils.py Outdated

Update tests/utils.py
8766612

AlexWaygood reviewed Jan 1, 2023
View reviewed changes

Comment threadtests/utils.py Outdated

Avasam added 3 commits January 1, 2023 03:53

Revert if TYPE_CHECKING
87324d4

Merge branch 'support-non-type-dependency-pyright' ofhttps://github.…
f2f0b8d
…com/Avasam/typeshed into support-non-type-dependency-pyright

Add doc about installing deps
1ea0b23

Avasam mentioned this pull request Jan 1, 2023
Add typing-extensions to requirements-tests.txt#9438
Merged

AlexWaygood reviewed Jan 1, 2023
View reviewed changes

Comment thread.github/workflows/tests.yml Outdated
Comment thread.github/workflows/tests.yml
Comment thread.github/workflows/tests.yml
Comment threadtests/README.md Outdated
Comment threadtests/README.md Outdated
Comment threadtests/README.md Outdated
Comment threadtests/README.md Outdated

Apply suggestions from code review
8dd53a2
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood reviewed Jan 1, 2023
View reviewed changes

Comment threadtests/README.md

AlexWaygood mentioned this pull request Jan 2, 2023
Allow non-types dependencies #5768
Closed

Avasam commented Jan 2, 2023
View reviewed changes

Comment threadtests/README.md Outdated

Update tests/README.md
807a8f4

AlexWaygood reviewed Jan 2, 2023
View reviewed changes

Comment threadtests/README.md Outdated

Update tests/README.md
1ff9c18
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood reviewed Jan 2, 2023
View reviewed changes

Comment threadtests/README.md Outdated

Oops another typo
5abb5e1

AlexWaygood approved these changes Jan 2, 2023
View reviewed changes

Avasam mentioned this pull request Jan 2, 2023
Add syntax highlight to all shell code blocks #9445
Merged

Rename scripts
dfa4085

Avasam mentioned this pull request Jan 3, 2023
Support third-party stub external dependencies in pytype #9449
Merged

Add some random non-types dependencies to see what happens
b5a2495

AlexWaygood force-pushed the support-non-type-dependency-pyright branch from 69974ae to b5a2495Compare January 3, 2023 22:08

AlexWaygoodand others added 2 commits January 3, 2023 22:17

Revert "Add some random non-types dependencies to see what happens"
fad4c7c
This reverts commit b5a2495.

Reflow docs to keep line length <90 characters where practical
a89c681

AlexWaygood approved these changes Jan 3, 2023
View reviewed changes

This comment was marked as outdated.
Sign in to view

AlexWaygood merged commit 3e24c65 into python:mainJan 3, 2023

Avasam deleted the support-non-type-dependency-pyright branch January 3, 2023 23:52

Uh oh!

Uh oh!

Conversation

Avasam commented Dec 31, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood commented Jan 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood commented Jan 1, 2023

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Avasam commented Jan 1, 2023

Uh oh!

AlexWaygood commented Jan 1, 2023

Uh oh!

AlexWaygood commented Jan 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Avasam commented Jan 2, 2023

Uh oh!

AlexWaygood commented Jan 3, 2023

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Avasam commented Dec 31, 2022•
edited
Loading

AlexWaygood commented Jan 1, 2023•
edited
Loading

AlexWaygood commented Jan 1, 2023•
edited
Loading