Uh oh!
There was an error while loading. Please reload this page.
Fix some Any subclassing in tqdm - #9505
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
There was a problem hiding this comment.
The keras and dask changes look great. Mind splitting the rich changes off into a separate PR? They're a little more complex and my brain's going a little fuzzy thinking about nominal vs structural subtyping 😅
Uh oh!
There was an error while loading. Please reload this page.
If it feels too complex for our needs, I can always make more things |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
commented
Jan 13, 2023
Maybe we could start off with something simpler for now? We can always refine it in the future :) |
Fixes
42 Any subclassing issues by replicating the types used in external modules.Therichone isn't complete as it was starting to get quite complex (I don't wanna re-implement the entire library's types either!)Ref: #9491