Uh oh!
There was an error while loading. Please reload this page.
Update Unused and __exit__ parameters in stdlib - #9519
Conversation
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Jan 13, 2023
Random CI failure, you can re-run just that job |
AlexWaygood
commented
Jan 13, 2023
Hmm, while support for arbitrary aliases in flake8-pyi is unrealistic, we could certainly add some special-casing for the |
AlexWaygood
commented
Jan 13, 2023
Are you interested in working on a flake8-pyi PR for this? If not, I can take a look at adding special-casing |
Avasam
commented
Jan 14, 2023
Sure. If I"m stuck I"ll let you know |
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
There was a problem hiding this comment.
Mostly looks good, but a few points below! Also, you have a fair few unused noqa comments following the new flake8-pyi release ;)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Thanks for looking into the methods I was uncertain about. I still have one unanswered question left:
|
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
Jan 17, 2023
Sure, why not! |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Follow up to #9475
Unusedtype alias for unused params.uuid.getnodeby correctly typing an undocumented/unused paramasyncio.runners.Runner.__exit__andsqlite3.dbapi2.Blob.__exit__usingtype[BaseException] | None, BaseException | None, TracebackType | Noneinstead of objects. I couldn't check the source for these two, so I'm not sure if the params are meant to be unsued.There's also 4
object | Nonein stdlib, should I change those toobjectas well?