Skip to content

Resolve stubtest allowlist entries for ldap3 - #9532

Merged
AlexWaygood merged 3 commits into
python:mainfrom
Avasam:gssapi-in-ldap3
Jan 14, 2023
Merged

Resolve stubtest allowlist entries for ldap3#9532
AlexWaygood merged 3 commits into
python:mainfrom
Avasam:gssapi-in-ldap3

Conversation

@Avasam

Copy link
Copy Markdown
Collaborator

No description provided.

@AlexWaygood

Copy link
Copy Markdown
Member

Looks like there's a bug in check_consistent.py. This line:

specified_stubtest_platforms=set(tool_stubtest.get("platforms", []))

Should be changed to:

specified_stubtest_platforms=set(tool_stubtest.get("platforms", ["linux"])) 

Feel free to fix it as part of this PR!

@AlexWaygood

Copy link
Copy Markdown
Member

On second thoughts, I'll send a PR to centralize metadata parsing in our tests. It'll reduce the risk of future bugs like this, and also be more type-safe.

@Avasam

Avasam commented Jan 14, 2023

Copy link
Copy Markdown
CollaboratorAuthor

On second thoughts, I'll send a PR to centralize metadata parsing in our tests. It'll reduce the risk of future bugs like this, and also be more type-safe.

That's actually something that's been nagging me at the back of my mind for a while. And even commented with hauntsaninja: #9298 (comment)
Reduce code duplication. Increased type safety for typeshed's own testing code. Consistent defaults. Easier for contributors. etc.
I think it could be a good idea to centralize it even across projects: https://github.com/typeshed-internal/stub_uploader/blob/main/stub_uploader/metadata.py

@AlexWaygood

Copy link
Copy Markdown
Member

Feel free to do the easy fix for check_consistent.py as part of this PR! I don't want to hold this PR up until another maintainer's had a chance to review #9534.

@AlexWaygoodAlexWaygood changed the title Use gssapi in ldap3Resolve stubtest allowlist entries for ldap3Jan 14, 2023
@AlexWaygood
AlexWaygood merged commit 0e36622 into python:mainJan 14, 2023
@Avasam
Avasam deleted the gssapi-in-ldap3 branch January 14, 2023 18:21
Avasam added a commit to Avasam/typeshed that referenced this pull request Jan 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Avasam@AlexWaygood