Skip to content

Update fpdf2 stubs to 2.6.1 - #9546

Merged
srittau merged 11 commits into
python:mainfrom
srittau:fpdf2-2.6.1
Jan 17, 2023
Merged

Update fpdf2 stubs to 2.6.1#9546
srittau merged 11 commits into
python:mainfrom
srittau:fpdf2-2.6.1

Conversation

@srittau

@srittausrittau commented Jan 16, 2023•
edited by AlexWaygood
Loading

Copy link
Copy Markdown
Collaborator

Closes#9542

srittau
srittau commented Jan 16, 2023
View reviewed changes
Comment threadstubs/fpdf2/fpdf/fpdf.pyi Outdated
Comment on lines +152 to +160
# The following definition crashes stubtest.
# def set_encryption(
# self,
# owner_password: str,
# user_password: str | None = None,
# encryption_method: EncryptionMethod | str = ...,
# permissions: AccessPermission = ...,
# encrypt_metadata: bool = False,
# ) -> None: ...

@srittausrittauJan 16, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs further investigation for which I didn't have time yet.

@srittausrittauJan 17, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran this against stubtest HEAD and this seems to fix it. I'll update the comment.

AlexWaygood
AlexWaygood reviewed Jan 16, 2023
View reviewed changes
Comment threadstubs/fpdf2/fpdf/fpdf.pyi Outdated
AlexWaygood
AlexWaygood reviewed Jan 16, 2023
View reviewed changes
Comment threadstubs/fpdf2/METADATA.toml Outdated
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood

AlexWaygood commented Jan 16, 2023

Copy link
Copy Markdown
Member

I think we'll need a pytype release that includes google/pytype@829c589 if you want to keep the string default values — or you could take them out for now, and add them back when we have the new pytype release

@srittausrittau mentioned this pull request Jan 16, 2023
Closed
@github-actions

This comment has been minimized.

Sign in to view
@srittau

srittau commented Jan 16, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@rchen152 Is there a timeline for the next pytype release? This is non-critical, since we can easily work around the issue, but if a release is due soon, I would rather wait.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Jan 17, 2023
View reviewed changes
Comment threadstubs/fpdf2/fpdf/fpdf.pyi Outdated
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood reviewed Jan 17, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few points

Comment threadstubs/fpdf2/fpdf/encryption.pyi
Comment threadstubs/fpdf2/fpdf/encryption.pyi Outdated
Comment threadstubs/fpdf2/fpdf/encryption.pyi
Comment threadstubs/fpdf2/fpdf/line_break.pyi
Comment threadstubs/fpdf2/fpdf/linearization.pyi Outdated
Comment threadstubs/fpdf2/fpdf/html.pyi
srittauand others added 2 commits January 17, 2023 13:11
@github-actions

github-actionsBot commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
srittau merged commit 7b848b4 into python:mainJan 17, 2023
@srittau
srittau deleted the fpdf2-2.6.1 branch January 17, 2023 12:25
@rchen152

rchen152 commented Jan 17, 2023

Copy link
Copy Markdown
Collaborator

@rchen152 Is there a timeline for the next pytype release? This is non-critical, since we can easily work around the issue, but if a release is due soon, I would rather wait.

Sorry for the delay! (Yesterday was MLK day here.) We usually aim to do one pytype release a week. It's a manual process, so there's no fixed schedule. Yesterday's nightly tests were clean, so I can cut a release right now, actually.

@AlexWaygood

AlexWaygood commented Jan 17, 2023

Copy link
Copy Markdown
Member

Yesterday's nightly tests were clean, so I can cut a release right now, actually.

That would be great, if possible! It would help unblock #9501

@rchen152

rchen152 commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

Done! The new pytype version is 2023.01.17.

@AlexWaygood

AlexWaygood commented Jan 18, 2023

Copy link
Copy Markdown
Member

Done! The new pytype version is 2023.01.17.

Amazing, thank you!

srittau added a commit to srittau/typeshed that referenced this pull request Jan 18, 2023
@srittau
[fpdf2] Restore string default values
65d62ca
Cf. python#9546
@srittausrittau mentioned this pull request Jan 18, 2023
Merged
AlexWaygood pushed a commit that referenced this pull request Jan 18, 2023
@srittau
[fpdf2] Restore string default values (#9562)
eb4d170
Cf. #9546
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srittau@AlexWaygood@rchen152