Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 2.1k
Stubs replace : Any | None with : Incomplete | None#9565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,18 @@ | ||
| from _typeshed import Incomplete | ||
| from typing import Any | ||
| class TSInfo: | ||
| rules: list[Any] | ||
| labels: list[Any] | ||
| sourceKey: Any | None | ||
| chunk_count: Any | None | ||
| memory_usage: Any | None | ||
| total_samples: Any | None | ||
| retention_msecs: Any | None | ||
| last_time_stamp: Any | None | ||
| first_time_stamp: Any | None | ||
| sourceKey: Incomplete | None | ||
| chunk_count: Incomplete | None | ||
| memory_usage: Incomplete | None | ||
| total_samples: Incomplete | None | ||
| retention_msecs: Incomplete | None | ||
| last_time_stamp: Incomplete | None | ||
| first_time_stamp: Incomplete | None | ||
| max_samples_per_chunk: Any | None | ||
| chunk_size: Any | None | ||
| duplicate_policy: Any | None | ||
| max_samples_per_chunk: Incomplete | None | ||
| chunk_size: Incomplete | None | ||
| duplicate_policy: Incomplete | None | ||
| def __init__(self, args) -> None: ... |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import importlib.abc | ||
| import types | ||
| import zipimport | ||
| from _typeshed import Self | ||
| from _typeshed import Incomplete, Self | ||
| from abc import ABCMeta | ||
| from collections.abc import Callable, Generator, Iterable, Sequence | ||
| from typing import IO, Any, TypeVar, overload | ||
| @@ -79,7 +79,7 @@ class Requirement: | ||
| specs: list[tuple[str, str]] | ||
| # TODO: change this to packaging.markers.Marker | None once we can import | ||
| # packaging.markers | ||
| marker: Any | None | ||
| marker: Incomplete | None | ||
Comment on lines
80
to
+82
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, we should, you know, take action on this comment now (in a separate PR) | ||
| @staticmethod | ||
| def parse(s: str | Iterable[str]) -> Requirement: ... | ||
| def __contains__(self, item: Distribution | str | tuple[str, ...]) -> bool: ... | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the ones in this file are stubgen artefacts; they were all added in https://github.com/python/typeshed/pull/7603/files. But, there's no source-code comment indicating why they used
Anyhere (and the comments on the PR thread give no insight), so I think it's fine to change theAnyuses in this file toIncomplete.(Same comment applies to a few other files touched by this PR.)