Uh oh!
There was an error while loading. Please reload this page.
[SQLAlchemy] Annotate row classes - #9568
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
commented
Jan 18, 2023
The new homeassistant warning is due the comment I left about The comment: # The count and index methods are inherited from Sequence.# If the result set contains columns with the same names, these# fields contains their respective values, instead. We don't reflect# this in the stubs.While we could of course type |
Is this another case for a permissive union? Maybe not if it's not that common. If a user knows they's using count and index column |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JelleZijlstra
commented
Mar 9, 2023
@srittau could you respond to Avasam's feedback? |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Avasam <samuel.06@hotmail.com>
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
commented
Mar 9, 2023
Whoops, I forgot about this PR. Thanks, @Avasam for the thorough PR. I think I addressed all the concerns, although I fixed things a bit differently. |
No description provided.