Uh oh!
There was an error while loading. Please reload this page.
Add more overloads to the re stubs to help out pyright - #9592
Merged
Conversation
AlexWaygood
marked this pull request as draft
January 26, 2023 17:45
AlexWaygood
marked this pull request as ready for review
January 26, 2023 17:52
AlexWaygood
marked this pull request as draft
January 26, 2023 18:03
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
Jan 26, 2023
MemberAuthor
#9593 is a simpler approach, but one which mypy might not like so much (let's see what mypy_primer says). |
AlexWaygood
commented
Jan 26, 2023
MemberAuthor
Mypy hates #9593, so I think this is the best we can do. |
AlexWaygood
marked this pull request as ready for review
January 26, 2023 18:25
Uh oh!
There was an error while loading. Please reload this page.
Contributor
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Jan 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9591