Skip to content

Bump various test dependencies - #9646

Merged
JelleZijlstra merged 6 commits into
mainfrom
bump-deps
Feb 1, 2023
Merged

Bump various test dependencies#9646
JelleZijlstra merged 6 commits into
mainfrom
bump-deps

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Feb 1, 2023

Copy link
Copy Markdown
Member

No description provided.

@AlexWaygoodAlexWaygood mentioned this pull request Feb 1, 2023
Closed
@srittau

srittau commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Could we put the black reformats into a separate PR? Remember that the commit message becomes a changelog entry for third-party stubs. (Something I always forget when merging.)

@AlexWaygood

AlexWaygood commented Feb 1, 2023

Copy link
Copy Markdown
MemberAuthor

Could we put the black reformats into a separate PR? Remember that the commit message becomes a changelog entry for third-party stubs. (Something I always forget when merging.)

Yes, makes sense

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood commented Feb 1, 2023
View reviewed changes
Comment threadstdlib/builtins.pyi Outdated
@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood

AlexWaygood commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

The third-party stubtest failure in beautifulsoup has already been noted in #9645, and is unrelated to this PR.

The changes to builtins.BaseExceptionGroup.__init__ and builtins.ExceptionGroup.__init__ are needed to satisfy a new pyright lint: see https://github.com/python/typeshed/actions/runs/4063554162/jobs/6995928535. These methods are actually overridden at runtime, from what I can see, so it seems fine to override them in the stub as well: https://github.com/python/cpython/blob/75227fba1dd1683289d90ada7abba237bff55d14/Objects/exceptions.c#L808-L819

@github-actions

github-actionsBot commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
JelleZijlstra merged commit 8000fbd into mainFeb 1, 2023
@JelleZijlstra
JelleZijlstra deleted the bump-deps branch February 1, 2023 14:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@srittau@JelleZijlstra