Skip to content

Use typing_extensions.Self in the stubs/ directory - #9702

Merged
srittau merged 8 commits into
python:mainfrom
AlexWaygood:Self-stubs
Feb 15, 2023
Merged

Use typing_extensions.Self in the stubs/ directory#9702
srittau merged 8 commits into
python:mainfrom
AlexWaygood:Self-stubs

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Feb 9, 2023

Copy link
Copy Markdown
Member

Note that this will mean that the changed third-party packages are no longer compatible with mypy <1.0. However, we've already broken compatibility with mypy <1.0 in several third-party stubs in #9689 and #9695¯\_(ツ)_/¯.

I used the same script as in #9694 to create the first commit in this PR.

@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood

AlexWaygood commented Feb 9, 2023

Copy link
Copy Markdown
MemberAuthor

I'm not sure I understand the pyright failures in the pika stubs. @erictraut are these legitimate errors being emitted by pyright here, in your opinion, or are these false positives?

@srittau

srittau commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

Note that this will mean that the changed third-party packages are no longer compatible with mypy <1.0.

We probably need to have a conversation how we can better signal type checker compatibility to our users, but for now I'm fine with breaking compatibility when a new type checker version comes out. Automatically upgrading type stub packages is dangerous in any case.

@erictraut

erictraut commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

@AlexWaygood, this looks like a bug in pyright. I'll try to get it fixed by the end of the day. If this is blocking you, I could do a hot fix release, or we could wait until next Tuesday for the normal weekly release.

@erictrauterictraut mentioned this pull request Feb 9, 2023
Closed
@AlexWaygood

AlexWaygood commented Feb 9, 2023

Copy link
Copy Markdown
MemberAuthor

If this is blocking you, I could do a hot fix release, or we could wait until next Tuesday for the normal weekly release.

Don't worry, I can easily revert the changes on the affected files for now. No need for a hotfix release, I don't think.

@github-actions

This comment has been minimized.

Sign in to view
@erictraut

erictraut commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

I've fixed the pyright bug. It will be included in the next weekly release (1.1.294).

@AlexWaygood

AlexWaygood commented Feb 10, 2023

Copy link
Copy Markdown
MemberAuthor

I've fixed the pyright bug. It will be included in the next weekly release (1.1.294).

Thank you very much!

@AlexWaygood

AlexWaygood commented Feb 15, 2023

Copy link
Copy Markdown
MemberAuthor

7fc50c6 of this PR can be reverted now that we've updated to the latest pyright in CI, but I don't have access to a computer right now and it doesn't seem possible to revert a commit on your phone

@github-actions

This comment has been minimized.

Sign in to view
@srittau

srittau commented Feb 15, 2023

Copy link
Copy Markdown
Collaborator

I've reverted 7fc50c6

@github-actions

github-actionsBot commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes Feb 15, 2023
View reviewed changes

@srittausrittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checking looks good.

@srittau
srittau merged commit 7180d02 into python:mainFeb 15, 2023
@AlexWaygood
AlexWaygood deleted the Self-stubs branch February 15, 2023 10:56
@AlexWaygood

AlexWaygood commented Feb 15, 2023

Copy link
Copy Markdown
MemberAuthor

I've reverted 7fc50c6

Thank you very much!

@efiopefiop mentioned this pull request Feb 16, 2023
Merged
efiop added a commit to treeverse/dvc that referenced this pull request Feb 16, 2023
@efiop
deps: bump mypy to 1.0.0
fd3945a
types-tqdm broke compatibility with mypy < 1 and looks like we will start running into other typeshed packages soon python/typeshed#9702
@efiopefiop mentioned this pull request Feb 16, 2023
Closed
neiljp added a commit to neiljp/zulip-terminal that referenced this pull request Feb 16, 2023
@neiljp
requirements[dev]: Upgrade mypy from ==0.961 to ~=1.0.0.
8a0107a
This is necessary since fresh environment builds (including CI) appear to pull
a version of types-requests that is broken with mypy < 1.0, types-requests
being the broken-out 3rd-party package of stubs for requests, but that is still
maintained in typeshed.
This appears to be python/typeshed#9702.
The mypy version is updated to ~=1.0.0 versioning now that it has moved to a
major/minor/point versioning scheme.
@neiljpneiljp mentioned this pull request Feb 16, 2023
Merged
4 tasks
neiljp added a commit to zulip/zulip-terminal that referenced this pull request Feb 16, 2023
@neiljp
requirements[dev]: Upgrade mypy from ==0.961 to ~=1.0.0.
ec19fd5
This is necessary since fresh environment builds (including CI) appear to pull
a version of types-requests that is broken with mypy < 1.0, types-requests
being the broken-out 3rd-party package of stubs for requests, but that is still
maintained in typeshed.
This appears to be python/typeshed#9702.
The mypy version is updated to ~=1.0.0 versioning now that it has moved to a
major/minor/point versioning scheme.
@jayaddisonjayaddison mentioned this pull request Feb 23, 2023
Merged
@tsibleytsibley mentioned this pull request Feb 27, 2023
Closed
tsibley added a commit to nextstrain/cli that referenced this pull request Feb 27, 2023
@tsibley
dev: Pin types-requests on Python 3.6 to a version that works with my…
7fda998
…py on 3.6
mypy 0.971 is the last version to support Python 3.6, so this is what
pip installs on 3.6.
types-requests 2.28.11.12 is the last version to support mypy <1.0.0,
due to changes in how the "Self" type is handled.¹ However, there's no
way to declare that in package metadata (without requiring mypy, which
is inappropriate for a typeshed package), so we have to resolve this
dependency ourselves.²
With a too-new types-requests, mypy fails on 3.6 with errors like:
nextstrain/cli/remote/nextstrain_dot_org.py:230: error: Self? has no attribute "auth"
which we saw in CI failures.³
We'll drop support for Python 3.6 sooner than later, but for now, keep
it going.
¹ <python/typeshed@7180d02>
<python/typeshed#9702>
² It would be possible if, for example, Python package metadata
supported a "Conflicts" field, as many packaging systems do.
³ <https://github.com/nextstrain/cli/actions/runs/4266385449/jobs/7426841852#step:5:78>
@tsibleytsibley mentioned this pull request Feb 27, 2023
Merged
1 task
@tsibley

tsibley commented Feb 27, 2023

Copy link
Copy Markdown

@srittauwrote:

We probably need to have a conversation how we can better signal type checker compatibility to our users, but for now I'm fine with breaking compatibility when a new type checker version comes out. Automatically upgrading type stub packages is dangerous in any case.

End user here. Better signaling would be nice. It's too bad there's no "Conflicts" field for Python package metadata, since it would be ~perfect for the third-party typeshed stub packages to declare which versions of type checkers they aren't compatible with.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittausrittausrittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexWaygood@srittau@erictraut@tsibley