Uh oh!
There was an error while loading. Please reload this page.
Stdlib: correct many parameter names - #9815
Merged
Merged
Conversation
AlexWaygood
commented
Feb 25, 2023
| class Event: | ||
| def __init__(self, lock: _LockLike | None = ..., *, ctx: BaseContext) -> None: ... | ||
| def __init__(self, *, ctx: BaseContext) -> None: ... |
MemberAuthor
There was a problem hiding this comment.
It doesn't look like this parameter has ever existed at runtime (from what I can see); I'm not sure how it made its way into the stub
This comment has been minimized.
This comment has been minimized.
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Two cases where the old names are better than the new names
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AlexWaygood
commented
Mar 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hauntsaninja
approved these changes
Mar 4, 2023
Contributor
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
commented
Mar 4, 2023
MemberAuthor
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I prepared this PR with the help of this script (which you'll notice has a very similar structure to
stubdefaulter).