Skip to content

add LiteralString - #1053

Merged
JelleZijlstra merged 11 commits into
python:masterfrom
JelleZijlstra:pep675
Feb 11, 2022
Merged

add LiteralString#1053
JelleZijlstra merged 11 commits into
python:masterfrom
JelleZijlstra:pep675

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Feb 2, 2022

Copy link
Copy Markdown
Member

Based on the latest revision of PEP 675 (cc @pradeep90).

The implementation is copied from Self, so the only interesting part is the docstring.

pradeep90
pradeep90 approved these changes Feb 2, 2022
View reviewed changes

@pradeep90pradeep90 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we wait in case someone has last-minute, heavy objections to the LiteralString name?

Comment threadtyping_extensions/src/test_typing_extensions.py
Comment threadtyping_extensions/src/test_typing_extensions.py Outdated
@JelleZijlstra

JelleZijlstra commented Feb 2, 2022

Copy link
Copy Markdown
MemberAuthor

Good idea, I'll hold off on merging for a while. I'm hoping to release typing-extensions 4.1 once we have PEP 646 support, dataclass_transform, all the functions I'm adding to typing, and this one all implemented.

@srittau
srittau marked this pull request as draft February 2, 2022 10:20
@srittau

srittau commented Feb 2, 2022

Copy link
Copy Markdown
Collaborator

I've converted this to a draft, just so I don't merge this by accident. Please unconvert (or merge) when ready.

@JelleZijlstraJelleZijlstra mentioned this pull request May 19, 2022
Closed
4 tasks
sobolevn
sobolevn reviewed Feb 10, 2022
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment threadtyping_extensions/src/typing_extensions.py
Comment threadtyping_extensions/src/test_typing_extensions.py
Comment threadtyping_extensions/src/test_typing_extensions.py
Comment threadtyping_extensions/src/test_typing_extensions.py
Comment threadtyping_extensions/src/test_typing_extensions.py
@JelleZijlstra
JelleZijlstra marked this pull request as ready for review February 11, 2022 02:15
JelleZijlstra
JelleZijlstra commented Feb 11, 2022
View reviewed changes
Comment threadtyping_extensions/CHANGELOG Outdated
@JelleZijlstra
JelleZijlstra merged commit f6e8272 into python:masterFeb 11, 2022
@JelleZijlstra
JelleZijlstra deleted the pep675 branch February 11, 2022 02:21
@pradeep90pradeep90 mentioned this pull request Feb 16, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittausrittausrittau approved these changes
+2 more reviewers
@sobolevnsobolevnsobolevn left review comments
@pradeep90pradeep90pradeep90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JelleZijlstra@srittau@pradeep90@sobolevn@the-knights-who-say-ni