Skip to content

Support 3.12 - #173

Merged
srittau merged 6 commits into
python:mainfrom
JelleZijlstra:test312
May 26, 2023
Merged

Support 3.12#173
srittau merged 6 commits into
python:mainfrom
JelleZijlstra:test312

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented May 22, 2023

Copy link
Copy Markdown
Member

No description provided.

@JelleZijlstra

JelleZijlstra commented May 22, 2023

Copy link
Copy Markdown
MemberAuthor

I guess this still runs alpha 7, which doesn't have a lot of stuff we need. Let's try again after beta 1 is released.

@AlexWaygood

AlexWaygood commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

We could use https://github.com/deadsnakes/action to test with a nightly build in CI. Or, yeah, we could just wait a few days :)

@AlexWaygood

AlexWaygood commented May 22, 2023

Copy link
Copy Markdown
Member

Guessing it'll be a few more days before actions/setup-python starts using 3.12b1 for 3.12-dev

@JelleZijlstra

JelleZijlstra commented May 22, 2023

Copy link
Copy Markdown
MemberAuthor

What, it was released like two hours ago :D

I think I'll cut the 4.6.0 release tonight without waiting for this, after manually confirming that things work on current 3.12.

@tmke8

tmke8 commented May 24, 2023

Copy link
Copy Markdown

Seems 3.12-beta1 was just made available (3 hours ago): https://github.com/actions/python-versions/releases/tag/3.12.0-beta.1-5071360807

@JelleZijlstra

JelleZijlstra commented May 24, 2023

Copy link
Copy Markdown
MemberAuthor

Looks like we're still getting alpha7

@tmke8

tmke8 commented May 24, 2023

Copy link
Copy Markdown

Sorry, it seems the manifest needs to be updated still:

@AlexWaygood

AlexWaygood commented May 25, 2023

Copy link
Copy Markdown
Member

We're now getting 3.12-beta1 in CI, but the new test that was added in #188 is failing on 3.12.

@AlexWaygood

AlexWaygood commented May 25, 2023

Copy link
Copy Markdown
Member

We're now getting 3.12-beta1 in CI, but the new test that was added in #188 is failing on 3.12.

It's a bug in CPython. Writing an issue up now.

@AlexWaygood

AlexWaygood commented May 25, 2023•
edited
Loading

Copy link
Copy Markdown
Member

We're now getting 3.12-beta1 in CI, but the new test that was added in #188 is failing on 3.12.

It's a bug in CPython. Writing an issue up now.

@AlexWaygoodAlexWaygood mentioned this pull request May 26, 2023
Merged
@AlexWaygood

AlexWaygood commented May 26, 2023

Copy link
Copy Markdown
Member

Following 5d51455, everything should now be green on 3.12 if you merge in main

AlexWaygood
AlexWaygood reviewed May 26, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
pickled. Patch by Alex Waygood.
- Fix tests and import on Python 3.12, where `typing.TypeVar` can no longer be
subclassed. Patch by Jelle Zijlstra.
subclassed. Add explicit support for Python 3.12. Patches by Jelle Zijlstra.

@AlexWaygoodAlexWaygoodMay 26, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Add explicit support for 3.12" bit needs to be moved to the top of the Changelog

@srittau
srittau merged commit 3e04a2d into python:mainMay 26, 2023
@JelleZijlstraJelleZijlstra mentioned this pull request Jun 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments
@srittausrittausrittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra@AlexWaygood@tmke8@srittau