Uh oh!
There was an error while loading. Please reload this page.
Reimplement TypedDict in a similar way to Python - #191
Conversation
JelleZijlstra
commented
May 24, 2023
Seems like |
AlexWaygood
commented
May 24, 2023
Conceptually, it's better for |
JelleZijlstra
commented
May 26, 2023
TypedDict now closely follows the implementation and tests in Python main, except for some interesting workarounds to get generics to work, and a few other details that don't work in old versions. |
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks good! Haven't reviewed the tests in depth, but I trust you're testing everything that's tested in CPython?
Looks like a few tests are failing on py312 btw
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
JelleZijlstra
commented
May 27, 2023
All green now! |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
No description provided.