Skip to content

Add support for PEP 705 - #284

Merged
JelleZijlstra merged 9 commits into
python:mainfrom
JelleZijlstra:pep705
Nov 29, 2023
Merged

Add support for PEP 705#284
JelleZijlstra merged 9 commits into
python:mainfrom
JelleZijlstra:pep705

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Sep 18, 2023

Copy link
Copy Markdown
Member

No description provided.

@JelleZijlstra

JelleZijlstra commented Sep 18, 2023

Copy link
Copy Markdown
MemberAuthor

Let's not merge this until python/peps#3440 is merged.

@JelleZijlstraJelleZijlstra mentioned this pull request Sep 18, 2023
Merged
4 tasks
srittau
srittau reviewed Sep 18, 2023
View reviewed changes
Comment threaddoc/index.rst Outdated
alicederyn
alicederyn reviewed Sep 19, 2023
View reviewed changes
Comment threaddoc/index.rst Outdated
AlexWaygood
AlexWaygood reviewed Sep 19, 2023
View reviewed changes
Comment threadsrc/typing_extensions.py Outdated
Comment threadsrc/typing_extensions.py Outdated
Comment threadsrc/typing_extensions.py Outdated
alicederyn
alicederyn reviewed Nov 8, 2023
View reviewed changes
Comment threadsrc/typing_extensions.py
@alicederyn

alicederyn commented Nov 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

PEP-705 has dropped both readonly and other_keys flags; only the typing.ReadOnly annotation needs to be added now.

@JelleZijlstraJelleZijlstra mentioned this pull request Nov 29, 2023
Closed
alicederyn
alicederyn reviewed Nov 29, 2023
View reviewed changes
Comment threadsrc/typing_extensions.py Outdated
alicederyn
alicederyn reviewed Nov 29, 2023
View reviewed changes
Comment threadsrc/typing_extensions.py Outdated
@JelleZijlstra@alicederyn
Apply suggestions from code review
e865252
Co-authored-by: Alice <Alice.Purcell.39@gmail.com>
AlexWaygood
AlexWaygood approved these changes Nov 29, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions (mostly optional), but overall this looks good!

Comment threadsrc/test_typing_extensions.py Outdated
Comment threadsrc/typing_extensions.py Outdated
Comment threadsrc/typing_extensions.py
Comment threadsrc/typing_extensions.py
JelleZijlstraand others added 2 commits November 29, 2023 09:39
@JelleZijlstra@AlexWaygood
Update src/test_typing_extensions.py
597c07a
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra@AlexWaygood
Apply suggestions from code review
deb966d
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Nov 29, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra
JelleZijlstra merged commit 0b0166d into python:mainNov 29, 2023
@JelleZijlstra
JelleZijlstra deleted the pep705 branch November 29, 2023 18:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittausrittausrittau left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
+1 more reviewer
@alicederynalicederynalicederyn left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra@alicederyn@srittau@AlexWaygood