Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary hasattr check from TypedDict - #533
Merged
Conversation
Daraan
marked this pull request as draft
February 22, 2025 17:12
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Daraanforce-pushed
the
TypedDict/backport__total__
branch
from
February 22, 2025 17:20
a3474f9 to
e2abebfCompareDaraan
marked this pull request as ready for review
February 22, 2025 17:21
JelleZijlstra
approved these changes
Feb 22, 2025
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Thanks, would you mind adding a changelog entry since this does change user-visible behavior in an edge case?
JelleZijlstra
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding @JelleZijlstra's PR python/cpython#109544
Including related additional tests from me python/cpython#130460 - not yet merged, hope that's fine.