Skip to content

Add Reader and Writer protocols - #582

Merged
srittau merged 10 commits into
python:mainfrom
srittau:reader-writer
Apr 30, 2025
Merged

Add Reader and Writer protocols#582
srittau merged 10 commits into
python:mainfrom
srittau:reader-writer

Conversation

@srittau

@srittausrittau commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

Cf. python/cpython#127648

#565 would help with testing this.

JelleZijlstra
JelleZijlstra reviewed Apr 9, 2025
View reviewed changes
Comment threadCHANGELOG.md Outdated
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment threadCHANGELOG.md Outdated
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment threadsrc/typing_extensions.py Outdated
srittauand others added 2 commits April 28, 2025 14:29
@srittau
Fix CHANGELOG
14f72d5
@srittau@AlexWaygood
Remove merge artifact
687d453
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment threadsrc/typing_extensions.py
AlexWaygood
AlexWaygood reviewed Apr 28, 2025
View reviewed changes
Comment threadsrc/test_typing_extensions.py Outdated
Comment threadsrc/test_typing_extensions.py Outdated
@srittau@AlexWaygood
Apply suggestions from code review
9e72db2
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood

AlexWaygood commented Apr 28, 2025

Copy link
Copy Markdown
Member

Should we add a mention of these to https://github.com/python/typing_extensions/blob/main/doc/index.rst ?

srittau
srittau commented Apr 28, 2025
View reviewed changes
Comment threaddoc/index.rst
AlexWaygood
AlexWaygood reviewed Apr 29, 2025
View reviewed changes
Comment threadsrc/typing_extensions.py Outdated
Comment threadsrc/typing_extensions.py Outdated
srittauand others added 2 commits April 29, 2025 14:09
@srittau@AlexWaygood
Use italics in docstring
b59461b
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@srittau
Silence flake8
f6e2fb0
@srittau
srittau merged commit f02b99d into python:mainApr 30, 2025
@srittau
srittau deleted the reader-writer branch April 30, 2025 13:08
@yashwanthatlayashwanthatla mentioned this pull request Jun 21, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srittau@AlexWaygood@JelleZijlstra