Uh oh!
There was an error while loading. Please reload this page.
Add some miscellaneous tests - #659
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The Python 3.10+ implementation started raising in PR#165
brianschubert
commented
Aug 30, 2025
Thanks for the review! I pushed a few changes. re: making |
Daraan
left a comment
There was a problem hiding this comment.
making ParamSpec.init_subclass raise in the 3.9 implementation, would this be worth a changelog mention? For reference, the 3.10+ implementation started raising in #165, which didn't include a changelog entry.
Imo, it's worth noting. That it is now consistent with the other versions.
Uh oh!
There was an error while loading. Please reload this page.
AlexWaygood
commented
Aug 30, 2025
Probably worth it, just to be safe? I feel like #165probably should have had a changelog mention too if it changed behaviour 😄 |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <alex.waygood@gmail.com>
Co-authored-by: Daraan <github.blurry@9ox.net>
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks great! I think there's a merge conflict
Uh oh!
There was an error while loading. Please reload this page.
Add tests to exercise some previously unexercised lines:
_SpecialGenericAlias.__setattr__()for non-dunder, non-"allowed" attributes (src)_SpecialGenericAliasfrom without defaults (src)_SpecialGenericAliaswith 0 type parameters (src)<thing>.__module__on Python implementations that don't supplysys._getframemodulenameorsys._getframe(src)get_type_hints()withtypes.GenericAlias(src)__init_subclass__()ofParamSpec(src)__or__()and__ror__()of_SpecialForm(src)__repr__and__reduce__ofNoExtraItems(test case copied fromNoDefaultTests) (src)