Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 140
Initial support for TypeVarLike default parameter (PEP 696)#77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aeeb1e8
Initial support for TypeVarLike default parameter (PEP 696)
cdce8p b900885
Update src/typing_extensions.py
cdce8p 4c412cf
Code review
cdce8p b24b4f8
Update src/typing_extensions.py
cdce8p c04112a
Revert conditional exports
cdce8p 088dd3e
Remove __slots__ from TypeVar
cdce8p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -21,6 +21,7 @@ | ||
| 'ParamSpecKwargs', | ||
| 'Self', | ||
| 'Type', | ||
| 'TypeVar', | ||
| 'TypeVarTuple', | ||
| 'Unpack', | ||
| @@ -1147,6 +1148,43 @@ def __repr__(self): | ||
| above.""") | ||
| class _DefaultMixin: | ||
| """Mixin for TypeVarLike defaults.""" | ||
| __slots__ = () | ||
| def __init__(self, default): | ||
| if isinstance(default, (tuple, list)): | ||
| self.__default__ = tuple((typing._type_check(d, "Default must be a type") | ||
| for d in default)) | ||
| elif default: | ||
| self.__default__ = typing._type_check(default, "Default must be a type") | ||
| else: | ||
| self.__default__ = None | ||
| # Add default Parameter - PEP 696 | ||
| class TypeVar(typing.TypeVar, _DefaultMixin, _root=True): | ||
| """Type variable.""" | ||
| __module__ = 'typing' | ||
| def __init__(self, name, *constraints, bound=None, | ||
| covariant=False, contravariant=False, | ||
| default=None): | ||
| super().__init__(name, *constraints, bound=bound, covariant=covariant, | ||
| contravariant=contravariant) | ||
| _DefaultMixin.__init__(self, default) | ||
| # for pickling: | ||
| try: | ||
| def_mod = sys._getframe(1).f_globals.get('__name__', '__main__') | ||
| except (AttributeError, ValueError): | ||
| def_mod = None | ||
| if def_mod != 'typing_extensions': | ||
| self.__module__ = def_mod | ||
| # Python 3.10+ has PEP 612 | ||
| if hasattr(typing, 'ParamSpecArgs'): | ||
| ParamSpecArgs = typing.ParamSpecArgs | ||
| @@ -1211,12 +1249,32 @@ def __eq__(self, other): | ||
| # 3.10+ | ||
| if hasattr(typing, 'ParamSpec'): | ||
cdce8p marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| ParamSpec = typing.ParamSpec | ||
| # Add default Parameter - PEP 696 | ||
| class ParamSpec(typing.ParamSpec, _DefaultMixin, _root=True): | ||
| """Parameter specification variable.""" | ||
| __module__ = 'typing' | ||
| def __init__(self, name, *, bound=None, covariant=False, contravariant=False, | ||
| default=None): | ||
| super().__init__(name, bound=bound, covariant=covariant, | ||
| contravariant=contravariant) | ||
| _DefaultMixin.__init__(self, default) | ||
| # for pickling: | ||
| try: | ||
| def_mod = sys._getframe(1).f_globals.get('__name__', '__main__') | ||
| except (AttributeError, ValueError): | ||
| def_mod = None | ||
| if def_mod != 'typing_extensions': | ||
| self.__module__ = def_mod | ||
| # 3.7-3.9 | ||
| else: | ||
| # Inherits from list as a workaround for Callable checks in Python < 3.9.2. | ||
| class ParamSpec(list): | ||
| class ParamSpec(list, _DefaultMixin): | ||
| """Parameter specification variable. | ||
| Usage:: | ||
| @@ -1274,7 +1332,8 @@ def args(self): | ||
| def kwargs(self): | ||
| return ParamSpecKwargs(self) | ||
| def __init__(self, name, *, bound=None, covariant=False, contravariant=False): | ||
| def __init__(self, name, *, bound=None, covariant=False, contravariant=False, | ||
| default=None): | ||
| super().__init__([self]) | ||
| self.__name__ = name | ||
| self.__covariant__ = bool(covariant) | ||
| @@ -1283,6 +1342,7 @@ def __init__(self, name, *, bound=None, covariant=False, contravariant=False): | ||
| self.__bound__ = typing._type_check(bound, 'Bound must be a type.') | ||
| else: | ||
| self.__bound__ = None | ||
| _DefaultMixin.__init__(self, default) | ||
| # for pickling: | ||
| try: | ||
| @@ -1784,9 +1844,25 @@ def _is_unpack(obj): | ||
| if hasattr(typing, "TypeVarTuple"): # 3.11+ | ||
| TypeVarTuple = typing.TypeVarTuple | ||
| # Add default Parameter - PEP 696 | ||
| class TypeVarTuple(typing.TypeVarTuple, _DefaultMixin, _root=True): | ||
| """Type variable tuple.""" | ||
| def __init__(self, name, *, default=None): | ||
| super().__init__(name) | ||
| _DefaultMixin.__init__(self, default) | ||
| # for pickling: | ||
| try: | ||
| def_mod = sys._getframe(1).f_globals.get('__name__', '__main__') | ||
| except (AttributeError, ValueError): | ||
| def_mod = None | ||
| if def_mod != 'typing_extensions': | ||
| self.__module__ = def_mod | ||
| else: | ||
| class TypeVarTuple: | ||
| class TypeVarTuple(_DefaultMixin): | ||
| """Type variable tuple. | ||
| Usage:: | ||
| @@ -1836,8 +1912,9 @@ def get_shape(self) -> Tuple[*Ts]: | ||
| def __iter__(self): | ||
| yield self.__unpacked__ | ||
| def __init__(self, name): | ||
| def __init__(self, name, *, default=None): | ||
| self.__name__ = name | ||
| _DefaultMixin.__init__(self, default) | ||
| # for pickling: | ||
| try: | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class should define empty slots to make TypeVar not have dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Although I'm not sure it will work. For 3.10
_TypeVarLikeand for 3.11_BoundVarianceMixindon't add__slots__, so the__dict__forTypeVaris created anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're interested, we can fix that for 3.12. (I'd be hesitant for older versions since it may break some users.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like
__slots__was removed on purpose since it didn't have any use. I've updated the PR to remove it fromTypeVaras well. Ref: python/cpython#30444