Uh oh!
There was an error while loading. Please reload this page.
WIP: Improve SpriteList doc - #1620
Closed
pushfoo wants to merge 15 commits into
Closed
Conversation
pushfooforce-pushed
the
improve_spritelist_doc
branch
3 times, most recently
from
March 9, 2023 05:00
5ceed89 to
cadb65aComparepushfoo
commented
Mar 21, 2023
MemberAuthor
This is blocked by #1639 and will need to be rebased on it |
pushfooforce-pushed
the
improve_spritelist_doc
branch
from
March 29, 2023 03:14
ff3b24a to
fedbcc0Comparepvcraven
commented
Apr 1, 2023
Member
Might want to consider future PRs to be smaller. Easier to review for us, quicker to get in, less risk of wasted work. |
pushfooforce-pushed
the
improve_spritelist_doc
branch
from
April 4, 2023 23:20
ecc6ba8 to
b3d8e52Comparepushfoo
commented
Apr 5, 2023
MemberAuthor
Definitely. This PR and #1639 both snowballed into much larger PRs due to being trial runs for concepts which will be applied elsewhere in the codebase. |
This was referenced Apr 7, 2023
pushfoo
commented
Oct 1, 2024
MemberAuthor
I'll just make a new PR for this. Enough has changed or already been incorporated that it's worth another pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My current intent is to split this into multiple smaller PRs. This one will end up being the
SpriteListdocstring rewrite.The others: