Skip to content

Minor improvements to GUI system - #1690

Merged
eruvanos merged 11 commits into
pythonarcade:developmentfrom
eschan145:widget_revamp
Jun 9, 2023
Merged

Minor improvements to GUI system#1690
eruvanos merged 11 commits into
pythonarcade:developmentfrom
eschan145:widget_revamp

Conversation

@eschan145

@eschan145eschan145 commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

The parameter docs look very ugly and compacted with the native RST formatting. Switching to Google-style would also leave me with more space to fit more characters per line.

eschan145and others added 5 commits April 4, 2023 16:08
@eschan145
Improve layout and formatting of concept.rst for GUI system docs
10ee9f9
Added a lot of documentation and a good tutorial on the GUI concepts. Also added more reStructuredText formatting.
@eschan145@pushfoo
Fix typo of "a" to "an" and "effecting" to "affecting"
b034b12
Thanks @pushfoo!
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
@eschan145
Apply suggestions to concept.rst by pushfoo
b14866e
* Wrapped lines to eighty characters
@eschan145
Documentation improvements to GUI text widgets
1247831
I intend to add some more commits later. I have to say, though, this traditional RST parameter formatting looks really ugly and I may need to squish text into very small areas.
I additionally added a `caret_color` parameter to `UIInputText` allowing users to specify a color for the caret.
@eschan145
Minor formatting fixes
f3ed9b3
* Fixed extra trailing whitespace
* Fixed missing colon
* Fixed missing import
@einarf
einarf requested a review from eruvanosApril 7, 2023 16:26
gran4
gran4 reviewed Apr 7, 2023
View reviewed changes
Comment threadarcade/gui/widgets/text.py Outdated
Comment threadarcade/gui/widgets/text.py Outdated
Comment threadarcade/gui/widgets/text.py Outdated
Comment threadarcade/gui/widgets/text.py Outdated
pushfoo
pushfoo reviewed Apr 8, 2023
View reviewed changes

@pushfoopushfoo left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on Caret being RGB-only in pyglet's source. That's something which needs to be addressed upstream. I'll give this PR a more thorough look later.

EDIT: I filed a ticket with pyglet checking for any blockers for making Caret take RGBA pyglet/pyglet#805

gran4
gran4 suggested changes Apr 19, 2023
View reviewed changes
Comment threadarcade/gui/widgets/text.py Outdated
@eruvanoseruvanos added the gui Related to arcade GUI (sub module arcade.gui) label Apr 19, 2023
@eruvanos

eruvanos commented Apr 25, 2023

Copy link
Copy Markdown
Member

@eschan145 For me it looks good in general, just fix the build error and we can merge it

@pushfoopushfoo mentioned this pull request May 2, 2023
Merged
@pushfoo

pushfoo commented May 2, 2023

Copy link
Copy Markdown
Member

Something may be wrong with Sphinx here. The error still occurs locally after removing the top-level docstring from UITextWidget.

@pushfoopushfoo mentioned this pull request May 3, 2023
Merged
pushfoo
pushfoo requested changes May 3, 2023
View reviewed changes

@pushfoopushfoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It's actually the \n in UITextWidget.multiline causing the error; make it \\n
  2. Our Sphinx version is broken, but I have a fix for that too (see #1745)

I have further suggestions, but the above should get this building & mergable. Having trouble fixing this isn't OP's fault.

Comment threadarcade/gui/widgets/text.py
eruvanosand others added 2 commits May 9, 2023 20:44
eruvanos
eruvanos reviewed May 18, 2023
View reviewed changes
Comment threaddoc/programming_guide/gui/concept.rst
@einarf

einarf commented Jun 9, 2023

Copy link
Copy Markdown
Member

Fixed the lingering issue with RGB just to check if things build. I'm guessing it should be RGBOrA, but I wasn't completely sure. @eruvanos knows?

@eruvanos
eruvanos merged commit 28c01ab into pythonarcade:developmentJun 9, 2023
@eruvanos

eruvanos commented Jun 9, 2023

Copy link
Copy Markdown
Member

Finally merged, thanks for your work

@pushfoopushfoo mentioned this pull request Sep 9, 2023
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eruvanoseruvanoseruvanos left review comments
@pushfoopushfoopushfoo requested changes
+1 more reviewer
@gran4gran4gran4 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

guiRelated to arcade GUI (sub module arcade.gui)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eschan145@eruvanos@pushfoo@einarf@gran4