Skip to content

Improved behavior of "visible" setter and getter properties in BasicSprite. - #2029

Merged
einarf merged 5 commits into
pythonarcade:developmentfrom
DragonMoffon:sprite-alpha-fix
Mar 23, 2024
Merged

Improved behavior of "visible" setter and getter properties in BasicSprite.#2029
einarf merged 5 commits into
pythonarcade:developmentfrom
DragonMoffon:sprite-alpha-fix

Conversation

@DragonMoffon

@DragonMoffonDragonMoffon commented Mar 19, 2024

Copy link
Copy Markdown
Collaborator

This is so the alpha state is stored when setting visibility. Originally, it overrode the alpha, which was stinky.

@DragonMoffon
add visible flag and strip out changing alpha when setting visible
cefb5b3
This is so the alpha state is stored when setting visibility. originally it overrode the alpha which was stinky.
@DragonMoffon
removed alpha assumption from sprite unit tests
c6ebe1c
@DragonMoffonDragonMoffon changed the title add visible flag and strip out changing alpha when setting visible.Add "visible" flag to BaseSpriteMar 19, 2024
pushfoo
pushfoo requested changes Mar 19, 2024
View reviewed changes

@pushfoopushfoo left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: There are nasty, subtle details which need changes to take care of.

The general changes are good, however. I also think we might have uncovered room for improvement in Color.from_iterable since we leave an unpack underflow uncaught, and it results in a somewhat vague exception.

Comment threadarcade/sprite/base.py
Comment threadtests/unit/sprite/test_sprite.py
Comment threadtests/unit/sprite/test_sprite.py
Comment threadtests/unit/sprite/test_sprite.py
Comment threadarcade/sprite/base.py
Comment threadarcade/sprite/base.py Outdated
@DragonMoffonDragonMoffon changed the title Add "visible" flag to BaseSpriteImproved behavior or "visible" setter and getter properties in BasicSprite.Mar 20, 2024
@DragonMoffonDragonMoffon changed the title Improved behavior or "visible" setter and getter properties in BasicSprite.Improved behavior of "visible" setter and getter properties in BasicSprite.Mar 20, 2024
pushfoo
pushfoo requested changes Mar 21, 2024
View reviewed changes

@pushfoopushfoo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix this while we're here.

Comment threadarcade/sprite/base.py Outdated
DragonMoffonand others added 2 commits March 21, 2024 16:33
@DragonMoffon
improved typing
f2677a8
@pushfoo
Improve docstring + comments for BasicSprite.visible (#4)
00a256d
* Correct and expand docstring for BasicSprite.visible
* Add comment explaining that SpriteList handles the alpha/visible interaction
@pushfoopushfoo mentioned this pull request Mar 21, 2024
Closed
@einarf
einarf merged commit b8dd7c3 into pythonarcade:developmentMar 23, 2024
@DragonMoffon
DragonMoffon deleted the sprite-alpha-fix branch April 10, 2024 05:00
@pushfoopushfoo mentioned this pull request Apr 10, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pushfoopushfoopushfoo requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DragonMoffon@pushfoo@einarf