Skip to content

Partial fix for PDF doc build - #2044

Merged
einarf merged 10 commits into
pythonarcade:developmentfrom
pushfoo:fix_doc_build_image_403s
Apr 16, 2024
Merged

Partial fix for PDF doc build#2044
einarf merged 10 commits into
pythonarcade:developmentfrom
pushfoo:fix_doc_build_image_403s

Conversation

@pushfoo

@pushfoopushfoo commented Apr 4, 2024

Copy link
Copy Markdown
Member

TL;DR: replaced 403ing images + added gif converter, but LaTex still broken

Changes

  • Replaced missing (403) links starting with camo.githubusercontent
    • When screenshots were available, I used those
    • For when they weren't, there's a pngcrushed placeholder image
  • Added imageconvert extension for PDF to convert gifs
  • Cleaned up Boxhead Survivor sampel game links + made them clickable
  • Added LaTeX build requirements notes

What's Still Broken / Untested

PDF Build: Still Broken

Running ./make.py latexpdf produces plenty of warnings and ends with this error and a LaTeX input prompt:

LaTeX Warning: Hyper reference `tutorials/platform_tutorial/index:platformer-tu
torial' on page 67 undefined on input line 2403.
[67 <./YI7uLX.jpg>] [68 <./screenshot1.png>]
Runaway argument?
{{example
! Paragraph ended before \\sphinxsafeincludegraphics was complete.
<to be read again> \par l.2483 ? 

EPUB build: Untested

Haven't gotten to this yet.

@pushfoo

Copy link
Copy Markdown
MemberAuthor

The test failures appear to be pyright upset about the GUI.

Comment threaddoc/example_code/game_jam_2020.rst Outdated
@pushfoo
pushfooforce-pushed the fix_doc_build_image_403s branch from 0406a93 to 05b01f7CompareApril 11, 2024 14:19
@pushfoo
pushfoo requested a review from pvcravenApril 11, 2024 17:29
@pushfoo
pushfooforce-pushed the fix_doc_build_image_403s branch from da450f9 to 587c4fcCompareApril 16, 2024 00:34
@pushfoo

Copy link
Copy Markdown
MemberAuthor

Rebased onto development to include #2062.

@einarf
einarf merged commit d625a01 into pythonarcade:developmentApr 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pushfoo@pvcraven@einarf