Uh oh!
There was an error while loading. Please reload this page.
[WIP] Move CI to Github Actions - #692
Conversation
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Codecov Report
@@ Coverage Diff @@## master #692 +/- ##
=========================================
Coverage ? 66.78% =========================================
Files ? 50 Lines ? 1993 Branches ? 0 =========================================
Hits ? 1331 Misses ? 662 Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
843fe55 to
9af2371Compare| # Basic Checks | ||
| - stage: primary | ||
| env: NOXSESSION=lint-3.5 | ||
| env: NOXSESSION=lint-3.8 |
There was a problem hiding this comment.
Maybe take out this change since we are planning to move away from Travis ?
There was a problem hiding this comment.
That is why the PR is labelled WIP. It is still functionally incomplete.
| run: | | ||
| pip install --upgrade pip | ||
| pip install nox | ||
| pip install coveralls |
There was a problem hiding this comment.
This shouldn't be required here
@palnabarun Does github CI doesn't have the concept of sessions/env ? I see you had to setup 2 separate workflow files.
Also test-3.6 and test-3.8 is being skipped due to missing interpreters |
palnabarun
commented
Jun 7, 2020
I didn't get you.
They are for different things. There is less clarity on how workflows should be structured, but functionally separating things seems to be the right way. |
palnabarun
commented
Jun 7, 2020
These things are being worked out and that is why the PR is WIP.
Yes. Again this is WIP. There are issues with nox detecting the right environments. If I need to install all Python versions when using nox, it completely defeats the purpose. Since, I can elegantly use matrix in Github Actions, each individual version of Python can be setup separately. When I did that, nox broke when Python 2.7 was the interpreter. I am working to resolve the issues. |
ananyo2012
commented
Jun 7, 2020
Sorry I missed the WIP label and went ahead and reviewd. More used to see WIP in title 😛 |
ananyo2012
commented
Jun 7, 2020
Yes indeed. Maybe GitHub CI doesn't support nox session like Travis does. Both the workflows has a lot of duplicate setup. Would be nice if there was some base setup from which things could be derived. |
palnabarun
commented
Jun 7, 2020
Ah. No problem. |
pradyunsg
commented
Jun 7, 2020
For Travis CI, the fix/workaround for the flakiness is to install their GitHub App, instead of using a webhook. OTOH, GitHub Actions is enough of an improvement in compute capacity, to justify switching IMO -- they give more "workers" per repo (20 + 5 MacOS), and their vCPUs are clocked higher (AFAIK). |
Travis CI is occasionally missing events from GitHub and hence becoming
very flaky to use, for example, in #682 and #689, the events are not being
detected at all.