Dockerize Junction by inovizz · Pull Request #749 · pythonindia/junction

inovizz · 2023-04-09T09:33:21Z

Fixes#750

ananyo2012

@inovizz Let's move out the warning fixes in a separate PR just to keep things easier to review.

Sc0rpi0n101

I think we should have .env in gitignore, not adding it to the repo.

We can add a .env.sample to help people in the case.

inovizz · 2023-04-12T18:32:18Z

@inovizz Let's move out the warning fixes in a separate PR just to keep things easier to review.

Yes, will remove the unnecessary code.

inovizz · 2023-04-12T18:32:41Z

I think we should have .env in gitignore, not adding it to the repo.
We can add a .env.sample to help people in the case.

Sure, will do it. Thanks.

ananyo2012

Left few comments

realslimshanky · 2023-04-16T07:08:31Z

Docker setup works fine for me. Moving forward with functional and code review.

realslimshanky

I've more ideas but let's merge this first and make junction functional first.

inovizz · 2023-04-18T04:11:33Z

@inovizz Let's move out the warning fixes in a separate PR just to keep things easier to review.

Looks like I don't have a lot of time to move this to a separate PR now, so we'll go as is. The fixes are any ways similar so shouldn't be a lot of effort to review.

inovizz · 2023-04-18T05:30:35Z

I've fixed a few things @realslimshanky @ananyo2012 & @Sc0rpi0n101. Can you have a glance once again?

Since I don't have a lot of bandwidth to contribute this week, I propose to merge the current working setup and we can request other volunteers to contribute on pending issues -

gunicorn setup
functional tests
Fix the CI pipeline, we could switch to Github actions or Fix Travis

Sc0rpi0n101

Added a few comments. Otherwise, Looks fine to me.

We can merge this for now and fix the other stuff in other PRs.

realslimshanky

Rest LGTM.

miphilomath · 2023-04-21T11:59:29Z

On attempting to login via home page, I am getting the following error.

Though If I login through admin site first, I am logged into the application with no error.

Is anyone else facing similar problem?

ananyo2012 · 2023-04-24T06:40:40Z

@miphilomath Can we continue conversation in this issue - #750 ?

…pplication

@rohitchopra-epam

* Upgrade Junction to Python 3.10 & Django 3.2 along with Social Login Fix (#744) * Upgrade Python Version to 3.10 and Django Version 3.2 * Fix Github and Google Login/Signup * new package added to the requirements file * using f-strings Co-authored-by: @rohitchopra-epam * Fix unit tests add gunicorn (#748) * Fix failing tests, Add gunicorn Added nox method for running gunicorn * Pin dependencies --------- Co-authored-by: Ananya Maiti <Ananya_Maiti@epam.com> * Dockerize Junction (#749) * Initial commit for Dockerization * Fix review comments and dockerignore * Update dev.py.sample with runsslserver * Fixes for using default settings module * Remove Dockerfile.celery and use image from junction web image * Update docker-compose.test.yml to not depend on postgres db * Add static asset compilation in Docker image * Add docker-compose.prod.yml and update server port configuration in application * Add social oauth env vars --------- Co-authored-by: Sanchit Balchandani <balchandani.sanchit@gmail.com> Co-authored-by: Ananya Maiti <Ananya_Maiti@epam.com> * Add SITE_PREFIX env variable for site url prefix * Fix smtp setup for sending verification emails * Fix conference moderator filter * Fix template params fro absolute_url and is_proposal_reviewer * Add Django streamhandler logging with DEBUG (#763) * Fix proposal comment template parameters Fix userprofile dashboard url * Add restart:always to containers * Fix comment creation error caused sparingly Add review_comments=False for default comment view for logged in user * Add password for Redis DB * Fixes#765 Sort ProposalSection in descending order of creation date in ProposalSectionReviewer Add form * Add autocomplete_field for Proposal Reviewer to enable searcheable dropdown in add form * Update DEFAULT_FROM_EMAIL * Update common.py * Added username field in edit profile form (Issue-769) (#771) Co-authored-by: Rajat Rajdeep <rajat.rajdeep@avasant.com> * Update Devlopment setup docs (#773) * Update Devlopment setup docs * Instructions for setting up junction using Docker post junction upgrade. (#761) * Added instructions in the ReadMe file for setting up junction using Docker post junction upgrade. * Updated the psycopg version to resolve - SCRAM authentication requires libpq version 10 issue. --------- Co-authored-by: Rajat Rajdeep <rajat.rajdeep@avasant.com> --------- Co-authored-by: Ananya Maiti <Ananya_Maiti@epam.com> Co-authored-by: Rajat Rajdeep <46029666+RajatRajdeep@users.noreply.github.com> Co-authored-by: Rajat Rajdeep <rajat.rajdeep@avasant.com> * Rename travis yml * Remove status badges from README --------- Co-authored-by: Bhandari423 <69859505+Bhandari423@users.noreply.github.com> Co-authored-by: Ananya Maiti <Ananya_Maiti@epam.com> Co-authored-by: Sanchit Balchandani <balchandani.sanchit@gmail.com> Co-authored-by: Rajat Rajdeep <46029666+RajatRajdeep@users.noreply.github.com> Co-authored-by: Rajat Rajdeep <rajat.rajdeep@avasant.com>

inovizz marked this pull request as draft April 9, 2023 09:33

Initial commit for Dockerization
38ef495

inovizz force-pushed the feature/dockerize-junction branch from 519901f to 38ef495Compare April 9, 2023 09:40

inovizz changed the title ~~Initial commit for Dockerization~~[WIP] Initial commit for DockerizationApr 9, 2023

inovizz changed the title ~~[WIP] Initial commit for Dockerization~~[WIP] Dockerize JunctionApr 9, 2023

ananyo2012 reviewed Apr 12, 2023
View reviewed changes

Sc0rpi0n101 reviewed Apr 12, 2023
View reviewed changes

ananyo2012 reviewed Apr 14, 2023
View reviewed changes

Comment threaddocker-compose.test.yml Outdated
Comment threaddocker-compose.yml Outdated

ananyo2012 reviewed Apr 14, 2023
View reviewed changes

Comment threaddocker-compose.yml Outdated

realslimshanky reviewed Apr 16, 2023
View reviewed changes

Fix review comments and dockerignore
ad98f4f

inovizz added the area/tooling label Apr 18, 2023

inovizz self-assigned this Apr 18, 2023

inovizz marked this pull request as ready for review April 18, 2023 05:33

inovizz changed the title ~~[WIP] Dockerize Junction~~Dockerize JunctionApr 18, 2023

Sc0rpi0n101 reviewed Apr 18, 2023
View reviewed changes

Comment threadsettings/common.py Outdated
Comment threaddocker-compose.yml Outdated

mohit-ess reviewed Apr 18, 2023
View reviewed changes

Comment threadwait-for-it.sh

Update dev.py.sample with runsslserver
6575a21

This was referenced Apr 18, 2023
Create new or fix the current CI pipeline #751
Open
Add gunicorn configuration, fix docs for docker setup #752
Closed
Update the docs post junction upgrade and docker setup #753
Closed

realslimshanky reviewed Apr 20, 2023
View reviewed changes

Comment threadDockerfile Outdated
Comment threaddocker-compose.yml Outdated

Fixes for using default settings module
3e1b41c

ananyo2012 force-pushed the feature/dockerize-junction branch from c6835fa to 3e1b41cCompare April 20, 2023 12:46

Remove Dockerfile.celery and use image from junction web image
6be717f

Update docker-compose.test.yml to not depend on postgres db
ceecde3

inovizz mentioned this pull request Apr 21, 2023
Add docker setup for Junction #750
Closed

Add static asset compilation in Docker image
c15891c

Add docker-compose.prod.yml and update server port configuration in a…
183be67
…pplication

ananyo2012 force-pushed the feature/dockerize-junction branch from 7868fba to 183be67Compare April 24, 2023 12:28

Add social oauth env vars
dabc5d6

inovizz merged commit 9caf34e into pythonindia:feature/upgrade-junctionApr 24, 2023

Uh oh!

Conversation

inovizz commented Apr 9, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ananyo2012 left a comment

Choose a reason for hiding this comment

Uh oh!

Sc0rpi0n101 left a comment

Choose a reason for hiding this comment

Uh oh!

inovizz commented Apr 12, 2023

Uh oh!

inovizz commented Apr 12, 2023

Uh oh!

ananyo2012 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

realslimshanky commented Apr 16, 2023

Uh oh!

realslimshanky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inovizz commented Apr 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inovizz commented Apr 18, 2023

Uh oh!

Sc0rpi0n101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

realslimshanky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miphilomath commented Apr 21, 2023

Uh oh!

ananyo2012 commented Apr 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

inovizz commented Apr 9, 2023•
edited
Loading

inovizz commented Apr 18, 2023•
edited
Loading