Skip to content

Use Grid layout for Conference listing - #793

Merged
ananyo2012 merged 4 commits into
pythonindia:masterfrom
mannar-1:cards-layout
Nov 7, 2024
Merged

Use Grid layout for Conference listing#793
ananyo2012 merged 4 commits into
pythonindia:masterfrom
mannar-1:cards-layout

Conversation

@mannar-1

@mannar-1mannar-1 commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

image
modified cards layout to above

@mannar-1mannar-1 mentioned this pull request Oct 30, 2024
Closed
ananyo2012
ananyo2012 reviewed Oct 31, 2024
View reviewed changes
Comment threadjunction/templates/pages/home_page.html Outdated
@ananyo2012ananyo2012 changed the title added cardsUse Grid layout for Conference listingOct 31, 2024
@ananyo2012ananyo2012 added the hacktoberfest Issues part of hacktoberfest label Oct 31, 2024
RajatRajdeep
RajatRajdeep suggested changes Oct 31, 2024
View reviewed changes

@RajatRajdeepRajatRajdeep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a screencast demonstrating the changes, transitions, and functionality across different screen sizes?

Comment threadjunction/static/css/app.css Outdated
Comment threadjunction/static/css/app.css Outdated
@mannar-1

mannar-1 commented Oct 31, 2024

Copy link
Copy Markdown
ContributorAuthor

mobile:
image
Tab:
image
Laptop:
image

@mannar-1

mannar-1 commented Oct 31, 2024

Copy link
Copy Markdown
ContributorAuthor

I made required changes and pushed what changes you told. please check ones

ananyo2012
ananyo2012 reviewed Nov 4, 2024
View reviewed changes
Comment threadjunction/templates/pages/home_page.html Outdated
@mannar-1

mannar-1 commented Nov 7, 2024

Copy link
Copy Markdown
ContributorAuthor

i removed black spaces and converted to px please check. Thank you

@ananyo2012ananyo2012 mentioned this pull request Nov 7, 2024
Closed
@ananyo2012
ananyo2012 merged commit 6b20a1d into pythonindia:masterNov 7, 2024
@ananyo2012

ananyo2012 commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

Thanks @mannar-1 . A good step towards UI re-design.

Ajaymalviy added a commit to Ajaymalviy/junction1 that referenced this pull request Nov 7, 2024
@Ajaymalviy
Merge pull request#1from pythonindia/master
8adcfab
Use Grid layout for Conference listing (pythonindia#793)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ananyo2012ananyo2012ananyo2012 approved these changes
+1 more reviewer
@RajatRajdeepRajatRajdeepRajatRajdeep approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfestIssues part of hacktoberfesthacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mannar-1@ananyo2012@RajatRajdeep@mannar9