Uh oh!
There was an error while loading. Please reload this page.
Added flux demo - #3418
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
narendasan
commented
Mar 3, 2025
Can the app display the inference time, might be nice to have some stats rendered live as you generate |
48a7c94 to
5a528f1CompareUh oh!
There was an error while loading. Please reload this page.
361fb76 to
0aeea36Compare9964674 to
cfbc9eaCompare6d8023c to
0bcda12Compare41139e9 to
f536ac6CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| from torch_tensorrt.dynamo.lowering.passes.pass_utils import ( | ||
| clean_up_graph_after_modifications, | ||
| ) | ||
There was a problem hiding this comment.
I think we should avoid copying the whole model scripts for measuring perf. Try using the sys.path approach and importing the model and just a perf loop. something like
importsysimportossys.path.append(torchtrt_root+"examples/dynamo/apps")
fromflux_demoimport*model=<insertFLUXmodel (fp16orfp8) >results=measure_flux_perf(.... )Uh oh!
There was an error while loading. Please reload this page.
9acbee6 to
0d9a008CompareThere was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/impl/quantize.py 2025-06-12 23:00:13.565607+00:00+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/impl/quantize.py 2025-06-12 23:00:38.626299+00:00@@ -73,11 +73,10 @@
max_bound = 127
elif num_bits == 8 and exponent_bits == 4:
dtype = trt.DataType.FP8
max_bound = 448
-
axis = None
# int8 weight quantization is per-channel quantization(it can have one or multiple amax values)
if dtype == trt.DataType.INT8 and amax.numel() > 1:
# if the amax has more than one element, calculate the axis, otherwise axis value will be ignored
amax_init_shape = amax.shape
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/constant_folding.py 2025-06-12 23:00:13.567607+00:00+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/passes/constant_folding.py 2025-06-12 23:00:39.100847+00:00@@ -98,16 +98,17 @@
class _TorchTensorRTConstantFolder(ConstantFolder): # type: ignore[misc]
def __init__(self, *args: Any, **kwargs: Any) -> None:
super().__init__(*args, **kwargs)
def is_impure(self, node: torch.fx.node.Node) -> bool:
- # Set of known quantization ops to be excluded from constant folding. + # Set of known quantization ops to be excluded from constant folding.
# Currently, we exclude all quantization ops coming from modelopt library.
quantization_ops = {}
try:
- # modelopt import ensures torch.ops.tensorrt.quantize_op.default is registered + # modelopt import ensures torch.ops.tensorrt.quantize_op.default is registered
import modelopt.torch.quantization as mtq
+
assert torch.ops.tensorrt.quantize_op.default
quantization_ops.add(torch.ops.tensorrt.quantize_op.default)
except Exception as e:
pass
if quantization_ops and node.target in quantization_ops:Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/impl/quantize.py 2025-06-13 20:58:57.556250+00:00+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/conversion/impl/quantize.py 2025-06-13 20:59:27.374709+00:00@@ -73,11 +73,10 @@
max_bound = 127
elif num_bits == 8 and exponent_bits == 4:
dtype = trt.DataType.FP8
max_bound = 448
-
axis = None
# int8 weight quantization is per-channel quantization(it can have one or multiple amax values)
if dtype == trt.DataType.INT8 and amax.numel() > 1:
# if the amax has more than one element, calculate the axis, otherwise axis value will be ignored
amax_init_shape = amax.shape
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: