Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swolchok merged 18 commits into from
May 9, 2025
Merged

Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments #10491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0c73438
Update
swolchok Apr 24, 2025
fb432fa
Update
swolchok Apr 24, 2025
d4b7578
Update
swolchok Apr 24, 2025
773b183
Update
swolchok Apr 25, 2025
e83385f
Update
swolchok Apr 25, 2025
9aa95d0
Update
swolchok Apr 25, 2025
8d8e297
Update
swolchok Apr 25, 2025
5bc4b0c
Update
swolchok Apr 25, 2025
8fbbdee
Update
swolchok Apr 25, 2025
b132388
Update
swolchok Apr 25, 2025
5f80f14
Update
swolchok Apr 25, 2025
b360be6
Update
swolchok Apr 25, 2025
0277317
Update
swolchok Apr 25, 2025
3842103
Update
swolchok Apr 25, 2025
f02359b
Update
swolchok May 8, 2025
92357fb
Update
swolchok May 8, 2025
bb413e6
Update
swolchok May 8, 2025
e388e96
Update
swolchok May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions kernels/portable/cpu/op_add.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
[val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
utils::apply_bitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::REALHBBF16>(
[val_alpha](const auto val_a, const auto val_b) {
return val_a + val_alpha * val_b;
},
ctx,
a,
utils::SupportedTensorDtypes::REALHBBF16,
b,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBBF16);
out);
});

return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
static constexpr const char op_name[] = "add.Scalar_out";

ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
[b, alpha](const CTYPE_COMPUTE val_a) {
utils::apply_unitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::SAME_AS_COMMON>(
[b, alpha](const auto val_a) {
CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
return val_a + val_alpha * val_b;
},
ctx,
a,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::SAME_AS_COMMON);
out);
});

return out;
Expand Down
10 changes: 6 additions & 4 deletions kernels/portable/cpu/op_addmm.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
n,
p);

utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
[alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
utils::apply_bitensor_elementwise_fn<
CTYPE,
op_name,
utils::SupportedTensorDtypes::REALHBF16>(
[alpha_val, beta_val](const auto val_a, const auto val_b) {
return val_a * alpha_val + val_b * beta_val;
},
ctx,
out,
utils::SupportedTensorDtypes::REALHBF16,
in,
utils::SupportedTensorDtypes::REALHBF16,
out,
utils::SupportedTensorDtypes::REALHBF16);
out);
}
});

Expand Down
10 changes: 6 additions & 4 deletions kernels/portable/cpu/op_atan2.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
static constexpr const char op_name[] = "atan2.out";

ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
[](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
utils::apply_bitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::FLOATHBF16>(
[](const auto val_a, const auto val_b) {
return std::atan2(val_a, val_b);
},
ctx,
a,
utils::SupportedTensorDtypes::REALHBBF16,
b,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::FLOATHBF16);
out);
});

return out;
Expand Down
18 changes: 12 additions & 6 deletions kernels/portable/cpu/op_clamp.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
static constexpr const char op_name[] = "clamp.out";

ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
utils::apply_unitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::SAME_AS_COMMON>(
[has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
// TODO: rewrite this to be vectorization-capable.
CTYPE_COMPUTE val_out = val_in;
if (has_min) {
val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
ctx,
in,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::SAME_AS_COMMON);
out);
});

return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
static constexpr const char op_name[] = "clamp.Tensor_out";

ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
utils::apply_tritensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::REALHBBF16>(
[has_min, has_max](
const CTYPE_COMPUTE val_in,
const CTYPE_COMPUTE val_min,
const CTYPE_COMPUTE val_max) {
// TODO: rewrite this to be vectorization-capable.
CTYPE_COMPUTE val_out = val_in;
if (has_min) {
val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
utils::SupportedTensorDtypes::REALHBBF16,
max,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBBF16);
out);
});

return out;
Expand Down
16 changes: 10 additions & 6 deletions kernels/portable/cpu/op_copy.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
} else {
ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
utils::apply_bitensor_elementwise_fn<
CTYPE,
op_name,
utils::SupportedTensorDtypes::REALHBBF16>(
[](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
ctx,
in,
utils::SupportedTensorDtypes::REALHBBF16,
src,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBBF16);
out);
});
}

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
} else {
ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
utils::apply_bitensor_elementwise_fn<
CTYPE,
op_name,
utils::SupportedTensorDtypes::REALHBBF16>(
[](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
ctx,
in,
utils::SupportedTensorDtypes::REALHBBF16,
src,
utils::SupportedTensorDtypes::REALHBBF16,
in,
utils::SupportedTensorDtypes::REALHBBF16);
in);
});
}

Expand Down
31 changes: 18 additions & 13 deletions kernels/portable/cpu/op_div.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
static constexpr const char op_name[] = "div.out";

ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
[](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
return val_a / val_b;
},
utils::apply_bitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::FLOATHBF16>(
[](const auto val_a, const auto val_b) { return val_a / val_b; },
ctx,
a,
utils::SupportedTensorDtypes::REALHBBF16,
b,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::FLOATHBF16);
out);
});

return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
bool div_by_zero_error = false;

ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
utils::apply_bitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::REALHBF16>(
[mode_is_trunc, &div_by_zero_error](
const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
// TODO: rewrite this to be vectorization-capable.
if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
if (val_b == 0) {
div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
utils::SupportedTensorDtypes::REALHBBF16,
b,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBF16);
out);
});

ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
[val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
utils::apply_unitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::SAME_AS_COMMON>(
[val_b](const auto val_a) { return val_a / val_b; },
ctx,
a,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::SAME_AS_COMMON);
out);
});

return out;
Expand Down
11 changes: 7 additions & 4 deletions kernels/portable/cpu/op_elu.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
ET_EXTRACT_SCALAR(scale, math_scale);
ET_EXTRACT_SCALAR(input_scale, math_input_scale);
const auto negcoef = math_alpha * math_scale;
utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
[negcoef, math_scale, math_input_scale](auto x) {
utils::apply_unitensor_elementwise_fn<
CTYPE,
op_name,
utils::SupportedTensorDtypes::SAME_AS_COMMON>(
[negcoef, math_scale, math_input_scale](const auto x) {
// TODO: rewrite this to be vectorization-capable.
return MathT(x) <= MathT(0)
? std::expm1(MathT(x) * math_input_scale) * negcoef
: MathT(x) * math_scale;
},
ctx,
in,
utils::SupportedTensorDtypes::FLOATHBF16,
out,
utils::SupportedTensorDtypes::SAME_AS_COMMON);
out);
});
return out;
}
Expand Down
9 changes: 6 additions & 3 deletions kernels/portable/cpu/op_floor_divide.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
bool div_by_zero_error = false;

ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
utils::apply_bitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::REALHBF16>(
[&div_by_zero_error](
const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
// TODO: rewrite this to be vectorization-capable.
if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
if (val_b == 0) {
div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
utils::SupportedTensorDtypes::REALHBBF16,
b,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBF16);
out);
});

ET_KERNEL_CHECK_MSG(
Expand Down
18 changes: 12 additions & 6 deletions kernels/portable/cpu/op_fmod.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
bool div_by_zero_error = false;

ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
utils::apply_bitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::REALHBF16>(
[&div_by_zero_error](
const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
// TODO: rewrite this to be vectorization-capable.
CTYPE_COMPUTE value = 0;
if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
utils::SupportedTensorDtypes::REALHBBF16,
b,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBF16);
out);
});

ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
utils::apply_unitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::REALHBF16>(
[val_b](const CTYPE_COMPUTE val_a) {
// TODO: rewrite this to be vectorization-capable.
CTYPE_COMPUTE value = std::fmod(val_a, val_b);
return value;
},
ctx,
a,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBF16);
out);
});

return out;
Expand Down
8 changes: 5 additions & 3 deletions kernels/portable/cpu/op_maximum.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
static constexpr const char op_name[] = "maximum.out";

ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
utils::apply_bitensor_elementwise_fn<
CTYPE_COMPUTE,
op_name,
utils::SupportedTensorDtypes::REALHBBF16>(
[](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
return utils::max_override(val_a, val_b);
},
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
utils::SupportedTensorDtypes::REALHBBF16,
b,
utils::SupportedTensorDtypes::REALHBBF16,
out,
utils::SupportedTensorDtypes::REALHBBF16);
out);
});

return out;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

swolchok
merged 18 commits into

from

May 9, 2025
 Merged


Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments
#10491
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


18 commits


Select commit
Hold shift + click to select a range
0c73438

Update


swolchok Apr 24, 2025
fb432fa

Update


swolchok Apr 24, 2025
d4b7578

Update


swolchok Apr 24, 2025
773b183

Update


swolchok Apr 25, 2025
e83385f

Update


swolchok Apr 25, 2025
9aa95d0

Update


swolchok Apr 25, 2025
8d8e297

Update


swolchok Apr 25, 2025
5bc4b0c

Update


swolchok Apr 25, 2025
8fbbdee

Update


swolchok Apr 25, 2025
b132388

Update


swolchok Apr 25, 2025
5f80f14

Update


swolchok Apr 25, 2025
b360be6

Update


swolchok Apr 25, 2025
0277317

Update


swolchok Apr 25, 2025
3842103

Update


swolchok Apr 25, 2025
f02359b

Update


swolchok May 8, 2025
92357fb

Update


swolchok May 8, 2025
bb413e6

Update


swolchok May 8, 2025
e388e96

Update


swolchok May 9, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 12 additions & 8 deletions
kernels/portable/cpu/op_add.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [val_alpha](const auto val_a, const auto val_b) {
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
 static constexpr const char op_name[] = "add.Scalar_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [b, alpha](const CTYPE_COMPUTE val_a) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [b, alpha](const auto val_a) {
 CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_addmm.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
 n,
 p);

 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 [alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [alpha_val, beta_val](const auto val_a, const auto val_b) {
 return val_a * alpha_val + val_b * beta_val;
 },
 ctx,
 out,
 utils::SupportedTensorDtypes::REALHBF16,
 in,
 utils::SupportedTensorDtypes::REALHBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 }
 });

Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_atan2.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
 static constexpr const char op_name[] = "atan2.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) {
 return std::atan2(val_a, val_b);
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_clamp.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
 static constexpr const char op_name[] = "clamp.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
 static constexpr const char op_name[] = "clamp.Tensor_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_tritensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [has_min, has_max](
 const CTYPE_COMPUTE val_in,
 const CTYPE_COMPUTE val_min,
 const CTYPE_COMPUTE val_max) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 max,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down

16 changes: 10 additions & 6 deletions
kernels/portable/cpu/op_copy.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
 std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });
 }

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
 std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 in,
 utils::SupportedTensorDtypes::REALHBBF16);
 in);
 });
 }

Expand Down

31 changes: 18 additions & 13 deletions
kernels/portable/cpu/op_div.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
 static constexpr const char op_name[] = "div.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return val_a / val_b;
 },
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [mode_is_trunc, &div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [val_b](const auto val_a) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

11 changes: 7 additions & 4 deletions
kernels/portable/cpu/op_elu.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
 ET_EXTRACT_SCALAR(scale, math_scale);
 ET_EXTRACT_SCALAR(input_scale, math_input_scale);
 const auto negcoef = math_alpha * math_scale;
 utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
 [negcoef, math_scale, math_input_scale](auto x) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [negcoef, math_scale, math_input_scale](const auto x) {
 // TODO: rewrite this to be vectorization-capable.
 return MathT(x) <= MathT(0)
 ? std::expm1(MathT(x) * math_input_scale) * negcoef
 : MathT(x) * math_scale;
 },
 ctx,
 in,
 utils::SupportedTensorDtypes::FLOATHBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });
 return out;
}
Expand Down

9 changes: 6 additions & 3 deletions
kernels/portable/cpu/op_floor_divide.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_fmod.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
 bool div_by_zero_error = false;

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = 0;
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [val_b](const CTYPE_COMPUTE val_a) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = std::fmod(val_a, val_b);
 return value;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 return out;
Expand Down

8 changes: 5 additions & 3 deletions
kernels/portable/cpu/op_maximum.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
 static constexpr const char op_name[] = "maximum.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return utils::max_override(val_a, val_b);
 },
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

swolchok
merged 18 commits into

from

May 9, 2025
 Merged


Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments
#10491
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


18 commits


Select commit
Hold shift + click to select a range
0c73438

Update


swolchok Apr 24, 2025
fb432fa

Update


swolchok Apr 24, 2025
d4b7578

Update


swolchok Apr 24, 2025
773b183

Update


swolchok Apr 25, 2025
e83385f

Update


swolchok Apr 25, 2025
9aa95d0

Update


swolchok Apr 25, 2025
8d8e297

Update


swolchok Apr 25, 2025
5bc4b0c

Update


swolchok Apr 25, 2025
8fbbdee

Update


swolchok Apr 25, 2025
b132388

Update


swolchok Apr 25, 2025
5f80f14

Update


swolchok Apr 25, 2025
b360be6

Update


swolchok Apr 25, 2025
0277317

Update


swolchok Apr 25, 2025
3842103

Update


swolchok Apr 25, 2025
f02359b

Update


swolchok May 8, 2025
92357fb

Update


swolchok May 8, 2025
bb413e6

Update


swolchok May 8, 2025
e388e96

Update


swolchok May 9, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 12 additions & 8 deletions
kernels/portable/cpu/op_add.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [val_alpha](const auto val_a, const auto val_b) {
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
 static constexpr const char op_name[] = "add.Scalar_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [b, alpha](const CTYPE_COMPUTE val_a) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [b, alpha](const auto val_a) {
 CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_addmm.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
 n,
 p);

 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 [alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [alpha_val, beta_val](const auto val_a, const auto val_b) {
 return val_a * alpha_val + val_b * beta_val;
 },
 ctx,
 out,
 utils::SupportedTensorDtypes::REALHBF16,
 in,
 utils::SupportedTensorDtypes::REALHBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 }
 });

Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_atan2.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
 static constexpr const char op_name[] = "atan2.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) {
 return std::atan2(val_a, val_b);
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_clamp.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
 static constexpr const char op_name[] = "clamp.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
 static constexpr const char op_name[] = "clamp.Tensor_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_tritensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [has_min, has_max](
 const CTYPE_COMPUTE val_in,
 const CTYPE_COMPUTE val_min,
 const CTYPE_COMPUTE val_max) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 max,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down

16 changes: 10 additions & 6 deletions
kernels/portable/cpu/op_copy.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
 std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });
 }

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
 std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 in,
 utils::SupportedTensorDtypes::REALHBBF16);
 in);
 });
 }

Expand Down

31 changes: 18 additions & 13 deletions
kernels/portable/cpu/op_div.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
 static constexpr const char op_name[] = "div.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return val_a / val_b;
 },
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [mode_is_trunc, &div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [val_b](const auto val_a) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

11 changes: 7 additions & 4 deletions
kernels/portable/cpu/op_elu.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
 ET_EXTRACT_SCALAR(scale, math_scale);
 ET_EXTRACT_SCALAR(input_scale, math_input_scale);
 const auto negcoef = math_alpha * math_scale;
 utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
 [negcoef, math_scale, math_input_scale](auto x) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [negcoef, math_scale, math_input_scale](const auto x) {
 // TODO: rewrite this to be vectorization-capable.
 return MathT(x) <= MathT(0)
 ? std::expm1(MathT(x) * math_input_scale) * negcoef
 : MathT(x) * math_scale;
 },
 ctx,
 in,
 utils::SupportedTensorDtypes::FLOATHBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });
 return out;
}
Expand Down

9 changes: 6 additions & 3 deletions
kernels/portable/cpu/op_floor_divide.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_fmod.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
 bool div_by_zero_error = false;

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = 0;
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [val_b](const CTYPE_COMPUTE val_a) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = std::fmod(val_a, val_b);
 return value;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 return out;
Expand Down

8 changes: 5 additions & 3 deletions
kernels/portable/cpu/op_maximum.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
 static constexpr const char op_name[] = "maximum.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return utils::max_override(val_a, val_b);
 },
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

swolchok
merged 18 commits into

from

May 9, 2025
 Merged


Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments
#10491
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


18 commits


Select commit
Hold shift + click to select a range
0c73438

Update


swolchok Apr 24, 2025
fb432fa

Update


swolchok Apr 24, 2025
d4b7578

Update


swolchok Apr 24, 2025
773b183

Update


swolchok Apr 25, 2025
e83385f

Update


swolchok Apr 25, 2025
9aa95d0

Update


swolchok Apr 25, 2025
8d8e297

Update


swolchok Apr 25, 2025
5bc4b0c

Update


swolchok Apr 25, 2025
8fbbdee

Update


swolchok Apr 25, 2025
b132388

Update


swolchok Apr 25, 2025
5f80f14

Update


swolchok Apr 25, 2025
b360be6

Update


swolchok Apr 25, 2025
0277317

Update


swolchok Apr 25, 2025
3842103

Update


swolchok Apr 25, 2025
f02359b

Update


swolchok May 8, 2025
92357fb

Update


swolchok May 8, 2025
bb413e6

Update


swolchok May 8, 2025
e388e96

Update


swolchok May 9, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 12 additions & 8 deletions
kernels/portable/cpu/op_add.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [val_alpha](const auto val_a, const auto val_b) {
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
 static constexpr const char op_name[] = "add.Scalar_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [b, alpha](const CTYPE_COMPUTE val_a) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [b, alpha](const auto val_a) {
 CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_addmm.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
 n,
 p);

 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 [alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [alpha_val, beta_val](const auto val_a, const auto val_b) {
 return val_a * alpha_val + val_b * beta_val;
 },
 ctx,
 out,
 utils::SupportedTensorDtypes::REALHBF16,
 in,
 utils::SupportedTensorDtypes::REALHBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 }
 });

Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_atan2.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
 static constexpr const char op_name[] = "atan2.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) {
 return std::atan2(val_a, val_b);
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_clamp.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
 static constexpr const char op_name[] = "clamp.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
 static constexpr const char op_name[] = "clamp.Tensor_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_tritensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [has_min, has_max](
 const CTYPE_COMPUTE val_in,
 const CTYPE_COMPUTE val_min,
 const CTYPE_COMPUTE val_max) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 max,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down

16 changes: 10 additions & 6 deletions
kernels/portable/cpu/op_copy.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
 std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });
 }

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
 std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 in,
 utils::SupportedTensorDtypes::REALHBBF16);
 in);
 });
 }

Expand Down

31 changes: 18 additions & 13 deletions
kernels/portable/cpu/op_div.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
 static constexpr const char op_name[] = "div.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return val_a / val_b;
 },
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [mode_is_trunc, &div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [val_b](const auto val_a) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

11 changes: 7 additions & 4 deletions
kernels/portable/cpu/op_elu.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
 ET_EXTRACT_SCALAR(scale, math_scale);
 ET_EXTRACT_SCALAR(input_scale, math_input_scale);
 const auto negcoef = math_alpha * math_scale;
 utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
 [negcoef, math_scale, math_input_scale](auto x) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [negcoef, math_scale, math_input_scale](const auto x) {
 // TODO: rewrite this to be vectorization-capable.
 return MathT(x) <= MathT(0)
 ? std::expm1(MathT(x) * math_input_scale) * negcoef
 : MathT(x) * math_scale;
 },
 ctx,
 in,
 utils::SupportedTensorDtypes::FLOATHBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });
 return out;
}
Expand Down

9 changes: 6 additions & 3 deletions
kernels/portable/cpu/op_floor_divide.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_fmod.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
 bool div_by_zero_error = false;

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = 0;
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [val_b](const CTYPE_COMPUTE val_a) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = std::fmod(val_a, val_b);
 return value;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 return out;
Expand Down

8 changes: 5 additions & 3 deletions
kernels/portable/cpu/op_maximum.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
 static constexpr const char op_name[] = "maximum.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return utils::max_override(val_a, val_b);
 },
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

swolchok
merged 18 commits into

from

May 9, 2025
 Merged


Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments
#10491
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


18 commits


Select commit
Hold shift + click to select a range
0c73438

Update


swolchok Apr 24, 2025
fb432fa

Update


swolchok Apr 24, 2025
d4b7578

Update


swolchok Apr 24, 2025
773b183

Update


swolchok Apr 25, 2025
e83385f

Update


swolchok Apr 25, 2025
9aa95d0

Update


swolchok Apr 25, 2025
8d8e297

Update


swolchok Apr 25, 2025
5bc4b0c

Update


swolchok Apr 25, 2025
8fbbdee

Update


swolchok Apr 25, 2025
b132388

Update


swolchok Apr 25, 2025
5f80f14

Update


swolchok Apr 25, 2025
b360be6

Update


swolchok Apr 25, 2025
0277317

Update


swolchok Apr 25, 2025
3842103

Update


swolchok Apr 25, 2025
f02359b

Update


swolchok May 8, 2025
92357fb

Update


swolchok May 8, 2025
bb413e6

Update


swolchok May 8, 2025
e388e96

Update


swolchok May 9, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 12 additions & 8 deletions
kernels/portable/cpu/op_add.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [val_alpha](const auto val_a, const auto val_b) {
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
 static constexpr const char op_name[] = "add.Scalar_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [b, alpha](const CTYPE_COMPUTE val_a) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [b, alpha](const auto val_a) {
 CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_addmm.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
 n,
 p);

 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 [alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [alpha_val, beta_val](const auto val_a, const auto val_b) {
 return val_a * alpha_val + val_b * beta_val;
 },
 ctx,
 out,
 utils::SupportedTensorDtypes::REALHBF16,
 in,
 utils::SupportedTensorDtypes::REALHBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 }
 });

Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_atan2.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
 static constexpr const char op_name[] = "atan2.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) {
 return std::atan2(val_a, val_b);
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_clamp.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
 static constexpr const char op_name[] = "clamp.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
 static constexpr const char op_name[] = "clamp.Tensor_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_tritensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [has_min, has_max](
 const CTYPE_COMPUTE val_in,
 const CTYPE_COMPUTE val_min,
 const CTYPE_COMPUTE val_max) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 max,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down

16 changes: 10 additions & 6 deletions
kernels/portable/cpu/op_copy.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
 std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });
 }

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
 std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 in,
 utils::SupportedTensorDtypes::REALHBBF16);
 in);
 });
 }

Expand Down

31 changes: 18 additions & 13 deletions
kernels/portable/cpu/op_div.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
 static constexpr const char op_name[] = "div.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return val_a / val_b;
 },
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [mode_is_trunc, &div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [val_b](const auto val_a) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

11 changes: 7 additions & 4 deletions
kernels/portable/cpu/op_elu.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
 ET_EXTRACT_SCALAR(scale, math_scale);
 ET_EXTRACT_SCALAR(input_scale, math_input_scale);
 const auto negcoef = math_alpha * math_scale;
 utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
 [negcoef, math_scale, math_input_scale](auto x) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [negcoef, math_scale, math_input_scale](const auto x) {
 // TODO: rewrite this to be vectorization-capable.
 return MathT(x) <= MathT(0)
 ? std::expm1(MathT(x) * math_input_scale) * negcoef
 : MathT(x) * math_scale;
 },
 ctx,
 in,
 utils::SupportedTensorDtypes::FLOATHBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });
 return out;
}
Expand Down

9 changes: 6 additions & 3 deletions
kernels/portable/cpu/op_floor_divide.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_fmod.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
 bool div_by_zero_error = false;

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = 0;
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [val_b](const CTYPE_COMPUTE val_a) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = std::fmod(val_a, val_b);
 return value;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 return out;
Expand Down

8 changes: 5 additions & 3 deletions
kernels/portable/cpu/op_maximum.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
 static constexpr const char op_name[] = "maximum.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return utils::max_override(val_a, val_b);
 },
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

swolchok
merged 18 commits into

from

May 9, 2025
 Merged


Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments
#10491
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


18 commits


Select commit
Hold shift + click to select a range
0c73438

Update


swolchok Apr 24, 2025
fb432fa

Update


swolchok Apr 24, 2025
d4b7578

Update


swolchok Apr 24, 2025
773b183

Update


swolchok Apr 25, 2025
e83385f

Update


swolchok Apr 25, 2025
9aa95d0

Update


swolchok Apr 25, 2025
8d8e297

Update


swolchok Apr 25, 2025
5bc4b0c

Update


swolchok Apr 25, 2025
8fbbdee

Update


swolchok Apr 25, 2025
b132388

Update


swolchok Apr 25, 2025
5f80f14

Update


swolchok Apr 25, 2025
b360be6

Update


swolchok Apr 25, 2025
0277317

Update


swolchok Apr 25, 2025
3842103

Update


swolchok Apr 25, 2025
f02359b

Update


swolchok May 8, 2025
92357fb

Update


swolchok May 8, 2025
bb413e6

Update


swolchok May 8, 2025
e388e96

Update


swolchok May 9, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 12 additions & 8 deletions
kernels/portable/cpu/op_add.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [val_alpha](const auto val_a, const auto val_b) {
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
 static constexpr const char op_name[] = "add.Scalar_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [b, alpha](const CTYPE_COMPUTE val_a) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [b, alpha](const auto val_a) {
 CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_addmm.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
 n,
 p);

 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 [alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [alpha_val, beta_val](const auto val_a, const auto val_b) {
 return val_a * alpha_val + val_b * beta_val;
 },
 ctx,
 out,
 utils::SupportedTensorDtypes::REALHBF16,
 in,
 utils::SupportedTensorDtypes::REALHBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 }
 });

Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_atan2.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
 static constexpr const char op_name[] = "atan2.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) {
 return std::atan2(val_a, val_b);
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_clamp.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
 static constexpr const char op_name[] = "clamp.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
 static constexpr const char op_name[] = "clamp.Tensor_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_tritensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [has_min, has_max](
 const CTYPE_COMPUTE val_in,
 const CTYPE_COMPUTE val_min,
 const CTYPE_COMPUTE val_max) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 max,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down

16 changes: 10 additions & 6 deletions
kernels/portable/cpu/op_copy.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
 std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });
 }

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
 std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 in,
 utils::SupportedTensorDtypes::REALHBBF16);
 in);
 });
 }

Expand Down

31 changes: 18 additions & 13 deletions
kernels/portable/cpu/op_div.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
 static constexpr const char op_name[] = "div.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return val_a / val_b;
 },
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [mode_is_trunc, &div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [val_b](const auto val_a) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

11 changes: 7 additions & 4 deletions
kernels/portable/cpu/op_elu.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
 ET_EXTRACT_SCALAR(scale, math_scale);
 ET_EXTRACT_SCALAR(input_scale, math_input_scale);
 const auto negcoef = math_alpha * math_scale;
 utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
 [negcoef, math_scale, math_input_scale](auto x) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [negcoef, math_scale, math_input_scale](const auto x) {
 // TODO: rewrite this to be vectorization-capable.
 return MathT(x) <= MathT(0)
 ? std::expm1(MathT(x) * math_input_scale) * negcoef
 : MathT(x) * math_scale;
 },
 ctx,
 in,
 utils::SupportedTensorDtypes::FLOATHBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });
 return out;
}
Expand Down

9 changes: 6 additions & 3 deletions
kernels/portable/cpu/op_floor_divide.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_fmod.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
 bool div_by_zero_error = false;

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = 0;
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [val_b](const CTYPE_COMPUTE val_a) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = std::fmod(val_a, val_b);
 return value;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 return out;
Expand Down

8 changes: 5 additions & 3 deletions
kernels/portable/cpu/op_maximum.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
 static constexpr const char op_name[] = "maximum.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return utils::max_override(val_a, val_b);
 },
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

swolchok
merged 18 commits into

from

May 9, 2025
 Merged


Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments
#10491
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


18 commits


Select commit
Hold shift + click to select a range
0c73438

Update


swolchok Apr 24, 2025
fb432fa

Update


swolchok Apr 24, 2025
d4b7578

Update


swolchok Apr 24, 2025
773b183

Update


swolchok Apr 25, 2025
e83385f

Update


swolchok Apr 25, 2025
9aa95d0

Update


swolchok Apr 25, 2025
8d8e297

Update


swolchok Apr 25, 2025
5bc4b0c

Update


swolchok Apr 25, 2025
8fbbdee

Update


swolchok Apr 25, 2025
b132388

Update


swolchok Apr 25, 2025
5f80f14

Update


swolchok Apr 25, 2025
b360be6

Update


swolchok Apr 25, 2025
0277317

Update


swolchok Apr 25, 2025
3842103

Update


swolchok Apr 25, 2025
f02359b

Update


swolchok May 8, 2025
92357fb

Update


swolchok May 8, 2025
bb413e6

Update


swolchok May 8, 2025
e388e96

Update


swolchok May 9, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 12 additions & 8 deletions
kernels/portable/cpu/op_add.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [val_alpha](const auto val_a, const auto val_b) {
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
 static constexpr const char op_name[] = "add.Scalar_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [b, alpha](const CTYPE_COMPUTE val_a) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [b, alpha](const auto val_a) {
 CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_addmm.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
 n,
 p);

 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 [alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [alpha_val, beta_val](const auto val_a, const auto val_b) {
 return val_a * alpha_val + val_b * beta_val;
 },
 ctx,
 out,
 utils::SupportedTensorDtypes::REALHBF16,
 in,
 utils::SupportedTensorDtypes::REALHBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 }
 });

Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_atan2.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
 static constexpr const char op_name[] = "atan2.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) {
 return std::atan2(val_a, val_b);
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_clamp.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
 static constexpr const char op_name[] = "clamp.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
 static constexpr const char op_name[] = "clamp.Tensor_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_tritensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [has_min, has_max](
 const CTYPE_COMPUTE val_in,
 const CTYPE_COMPUTE val_min,
 const CTYPE_COMPUTE val_max) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 max,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down

16 changes: 10 additions & 6 deletions
kernels/portable/cpu/op_copy.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
 std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });
 }

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
 std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 in,
 utils::SupportedTensorDtypes::REALHBBF16);
 in);
 });
 }

Expand Down

31 changes: 18 additions & 13 deletions
kernels/portable/cpu/op_div.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
 static constexpr const char op_name[] = "div.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return val_a / val_b;
 },
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [mode_is_trunc, &div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [val_b](const auto val_a) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

11 changes: 7 additions & 4 deletions
kernels/portable/cpu/op_elu.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
 ET_EXTRACT_SCALAR(scale, math_scale);
 ET_EXTRACT_SCALAR(input_scale, math_input_scale);
 const auto negcoef = math_alpha * math_scale;
 utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
 [negcoef, math_scale, math_input_scale](auto x) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [negcoef, math_scale, math_input_scale](const auto x) {
 // TODO: rewrite this to be vectorization-capable.
 return MathT(x) <= MathT(0)
 ? std::expm1(MathT(x) * math_input_scale) * negcoef
 : MathT(x) * math_scale;
 },
 ctx,
 in,
 utils::SupportedTensorDtypes::FLOATHBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });
 return out;
}
Expand Down

9 changes: 6 additions & 3 deletions
kernels/portable/cpu/op_floor_divide.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_fmod.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
 bool div_by_zero_error = false;

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = 0;
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [val_b](const CTYPE_COMPUTE val_a) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = std::fmod(val_a, val_b);
 return value;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 return out;
Expand Down

8 changes: 5 additions & 3 deletions
kernels/portable/cpu/op_maximum.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
 static constexpr const char op_name[] = "maximum.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return utils::max_override(val_a, val_b);
 },
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments#10491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

swolchok
merged 18 commits into

from

May 9, 2025
 Merged


Reapply #9841: Migrate elementwise_util callers to the variants with out_dtypes in template arguments
#10491
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


18 commits


Select commit
Hold shift + click to select a range
0c73438

Update


swolchok Apr 24, 2025
fb432fa

Update


swolchok Apr 24, 2025
d4b7578

Update


swolchok Apr 24, 2025
773b183

Update


swolchok Apr 25, 2025
e83385f

Update


swolchok Apr 25, 2025
9aa95d0

Update


swolchok Apr 25, 2025
8d8e297

Update


swolchok Apr 25, 2025
5bc4b0c

Update


swolchok Apr 25, 2025
8fbbdee

Update


swolchok Apr 25, 2025
b132388

Update


swolchok Apr 25, 2025
5f80f14

Update


swolchok Apr 25, 2025
b360be6

Update


swolchok Apr 25, 2025
0277317

Update


swolchok Apr 25, 2025
3842103

Update


swolchok Apr 25, 2025
f02359b

Update


swolchok May 8, 2025
92357fb

Update


swolchok May 8, 2025
bb413e6

Update


swolchok May 8, 2025
e388e96

Update


swolchok May 9, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 12 additions & 8 deletions
kernels/portable/cpu/op_add.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,17 +52,19 @@ Tensor& add_out(

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_alpha](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [val_alpha](const auto val_a, const auto val_b) {
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -100,17 +102,19 @@ Tensor& add_scalar_out(
 static constexpr const char op_name[] = "add.Scalar_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [b, alpha](const CTYPE_COMPUTE val_a) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [b, alpha](const auto val_a) {
 CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 CTYPE_COMPUTE val_alpha = utils::scalar_to<CTYPE_COMPUTE>(alpha);
 return val_a + val_alpha * val_b;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_addmm.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,17 +88,19 @@ Tensor& addmm_out(
 n,
 p);

 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 [alpha_val, beta_val](const CTYPE val_a, const CTYPE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [alpha_val, beta_val](const auto val_a, const auto val_b) {
 return val_a * alpha_val + val_b * beta_val;
 },
 ctx,
 out,
 utils::SupportedTensorDtypes::REALHBF16,
 in,
 utils::SupportedTensorDtypes::REALHBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 }
 });

Expand Down

10 changes: 6 additions & 4 deletions
kernels/portable/cpu/op_atan2.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,17 +55,19 @@ Tensor& atan2_out(
 static constexpr const char op_name[] = "atan2.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) {
 return std::atan2(val_a, val_b);
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_clamp.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -134,8 +134,12 @@ Tensor& clamp_out(
 static constexpr const char op_name[] = "clamp.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [has_min, min_opt, has_max, max_opt](const CTYPE_COMPUTE val_in) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(
Expand All@@ -150,8 +154,7 @@ Tensor& clamp_out(
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand DownExpand Up@@ -210,11 +213,15 @@ Tensor& clamp_tensor_out(
 static constexpr const char op_name[] = "clamp.Tensor_out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_tritensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_tritensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [has_min, has_max](
 const CTYPE_COMPUTE val_in,
 const CTYPE_COMPUTE val_min,
 const CTYPE_COMPUTE val_max) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE val_out = val_in;
 if (has_min) {
 val_out = utils::max_override(val_out, val_min);
Expand All@@ -231,8 +238,7 @@ Tensor& clamp_tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 max,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down

16 changes: 10 additions & 6 deletions
kernels/portable/cpu/op_copy.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,15 +53,17 @@ Tensor& copy_out(
 std::memcpy(out.mutable_data_ptr(), src.const_data_ptr(), src.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy.out", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });
 }

Expand DownExpand Up@@ -93,15 +95,17 @@ Tensor& copy_(
 std::memcpy(in.mutable_data_ptr(), src.const_data_ptr(), in.nbytes());
 } else {
 ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, "copy_", CTYPE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](ET_UNUSED const CTYPE _, const CTYPE val_src) { return val_src; },
 ctx,
 in,
 utils::SupportedTensorDtypes::REALHBBF16,
 src,
 utils::SupportedTensorDtypes::REALHBBF16,
 in,
 utils::SupportedTensorDtypes::REALHBBF16);
 in);
 });
 }

Expand Down

31 changes: 18 additions & 13 deletions
kernels/portable/cpu/op_div.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -58,17 +58,17 @@ Tensor& div_out(
 static constexpr const char op_name[] = "div.out";

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return val_a / val_b;
 },
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::FLOATHBF16>(
 [](const auto val_a, const auto val_b) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::FLOATHBF16);
 out);
 });

 return out;
Expand DownExpand Up@@ -122,9 +122,13 @@ Tensor& div_out_mode(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [mode_is_trunc, &div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -146,8 +150,7 @@ Tensor& div_out_mode(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -188,13 +191,15 @@ Tensor& div_scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 [val_b](const CTYPE_COMPUTE val_a) { return val_a / val_b; },
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [val_b](const auto val_a) { return val_a / val_b; },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });

 return out;
Expand Down

11 changes: 7 additions & 4 deletions
kernels/portable/cpu/op_elu.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -44,17 +44,20 @@ Tensor& elu_out(
 ET_EXTRACT_SCALAR(scale, math_scale);
 ET_EXTRACT_SCALAR(input_scale, math_input_scale);
 const auto negcoef = math_alpha * math_scale;
 utils::apply_unitensor_elementwise_fn<CTYPE, op_name>(
 [negcoef, math_scale, math_input_scale](auto x) {
 utils::apply_unitensor_elementwise_fn<
 CTYPE,
 op_name,
 utils::SupportedTensorDtypes::SAME_AS_COMMON>(
 [negcoef, math_scale, math_input_scale](const auto x) {
 // TODO: rewrite this to be vectorization-capable.
 return MathT(x) <= MathT(0)
 ? std::expm1(MathT(x) * math_input_scale) * negcoef
 : MathT(x) * math_scale;
 },
 ctx,
 in,
 utils::SupportedTensorDtypes::FLOATHBF16,
 out,
 utils::SupportedTensorDtypes::SAME_AS_COMMON);
 out);
 });
 return out;
}
Expand Down

9 changes: 6 additions & 3 deletions
kernels/portable/cpu/op_floor_divide.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,13 @@ Tensor& floor_divide_out(
 bool div_by_zero_error = false;

 ET_SWITCH_REAL_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
 div_by_zero_error = true;
Expand All@@ -69,8 +73,7 @@ Tensor& floor_divide_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand Down

18 changes: 12 additions & 6 deletions
kernels/portable/cpu/op_fmod.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -55,9 +55,13 @@ Tensor& fmod_Tensor_out(
 bool div_by_zero_error = false;

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [&div_by_zero_error](
 const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = 0;
 if (is_integral_type<CTYPE_COMPUTE, /*includeBool=*/true>::value) {
 if (val_b == 0) {
Expand All@@ -73,8 +77,7 @@ Tensor& fmod_Tensor_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 ET_KERNEL_CHECK_MSG(
Expand DownExpand Up@@ -131,16 +134,19 @@ Tensor& fmod_Scalar_out(

 ET_SWITCH_FLOAT_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 const CTYPE_COMPUTE val_b = utils::scalar_to<CTYPE_COMPUTE>(b);
 utils::apply_unitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_unitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBF16>(
 [val_b](const CTYPE_COMPUTE val_a) {
 // TODO: rewrite this to be vectorization-capable.
 CTYPE_COMPUTE value = std::fmod(val_a, val_b);
 return value;
 },
 ctx,
 a,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBF16);
 out);
 });

 return out;
Expand Down

8 changes: 5 additions & 3 deletions
kernels/portable/cpu/op_maximum.cpp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,10 @@ Tensor& maximum_out(
 static constexpr const char op_name[] = "maximum.out";

 ET_SWITCH_REALB_TYPES(compute_type, ctx, op_name, CTYPE_COMPUTE, [&]() {
 utils::apply_bitensor_elementwise_fn<CTYPE_COMPUTE, op_name>(
 utils::apply_bitensor_elementwise_fn<
 CTYPE_COMPUTE,
 op_name,
 utils::SupportedTensorDtypes::REALHBBF16>(
 [](const CTYPE_COMPUTE val_a, const CTYPE_COMPUTE val_b) {
 return utils::max_override(val_a, val_b);
 },
Expand All@@ -54,8 +57,7 @@ Tensor& maximum_out(
 utils::SupportedTensorDtypes::REALHBBF16,
 b,
 utils::SupportedTensorDtypes::REALHBBF16,
 out,
 utils::SupportedTensorDtypes::REALHBBF16);
 out);
 });

 return out;
Expand Down
Loading