Uh oh!
There was an error while loading. Please reload this page.
Make constant_folding's _DEFAULT_SKIP_TARGETS public - #10760
Merged
Conversation
ThomasJannaud
requested review from
JacobSzwejbka, larryliu0820 and tarun292
as code ownersMay 7, 2025 22:19
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10760
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c478189 with merge base a37b369 ( NEW FAILURE - The following job has failed:This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
commented
May 7, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D74349918 |
ThomasJannaud added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: This follows D73513516 and allows customers of constant_prop_pass to use previous defaults Differential Revision: D74349918
ThomasJannaudforce-pushed
the
export-D74349918
branch
from
May 8, 2025 16:03
dcfe91b to
9164e51Comparefacebook-github-bot
commented
May 8, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D74349918 |
ThomasJannaud added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: Pull Request resolved: pytorch#10760 This follows D73513516 and allows customers of constant_prop_pass to use previous defaults Differential Revision: D74349918
ThomasJannaudforce-pushed
the
export-D74349918
branch
from
May 8, 2025 16:06
9164e51 to
6c603deCompareJacobSzwejbka
approved these changes
May 8, 2025
JacobSzwejbka
left a comment
Contributor
There was a problem hiding this comment.
looks a bit weird since both sets are the same here but I guess its fine
ThomasJannaud added a commit
to ThomasJannaud/executorch
that referenced
this pull request
May 8, 2025
Summary: This follows D73513516 and allows customers of constant_prop_pass to use previous defaults Reviewed By: JacobSzwejbka Differential Revision: D74349918
ThomasJannaudforce-pushed
the
export-D74349918
branch
from
May 8, 2025 18:31
6c603de to
1daa831Comparefacebook-github-bot
commented
May 8, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D74349918 |
Summary: This follows D73513516 and allows customers of constant_prop_pass to use previous defaults This goes with D74350331 and D74280168 Reviewed By: JacobSzwejbka Differential Revision: D74349918
ThomasJannaudforce-pushed
the
export-D74349918
branch
from
May 8, 2025 19:24
1daa831 to
c478189Comparefacebook-github-bot
commented
May 8, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D74349918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This follows D73513516 and allows customers of constant_prop_pass to use previous defaults
Differential Revision: D74349918