[2/N] Add option context by cccclai · Pull Request #11390 · pytorch/executorch

cccclai · 2025-06-05T04:15:09Z

Stack from ghstack (oldest at bottom):

For future needs without breacking API BC, in case we need to pass more information to the update API

Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

pytorch-bot · 2025-06-05T04:15:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11390

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ea9679d with merge base 222d9e3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-06-05T04:15:28Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

facebook-github-bot · 2025-06-06T23:50:29Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

facebook-github-bot · 2025-06-10T18:40:11Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T21:36:51Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-17T18:23:22Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-18T05:54:27Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-18T06:05:51Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-23T05:08:00Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-23T05:11:51Z

This pull request was exported from Phabricator. Differential Revision: D75919212

kimishpatel

I am not sure on the use of this. I understand you said this is introduced for BC, but can you elaborate on the BC aspect of it? Is it to avoid makign changes to client call sites? If this struct is populated then I imagine it will require client callsites to change anyway, if they want to make use of it. So maybe a bit more on this in the summary would be good.

If you do want to keep it then maybe get_option and set_option should provide both overloads? One with backendoptioncontext and one without..

cccclai · 2025-06-23T18:37:16Z

I am not sure on the use of this. I understand you said this is introduced for BC, but can you elaborate on the BC aspect of it? Is it to avoid makign changes to client call sites? If this struct is populated then I imagine it will require client callsites to change anyway, if they want to make use of it. So maybe a bit more on this in the summary would be good.
If you do want to keep it then maybe get_option and set_option should provide both overloads? One with backendoptioncontext and one without..

Yeah to avoid making change to client call sites. I was thinking it's for pupulating runtime info from ET to the backend during set option. We can take a look at how init context helps on passing new info from ET to backend without causing BC.

Like when we pass event tracer: 0c4053e

And the named data map:
492366a

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-23T18:38:43Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-23T23:40:44Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-24T00:03:45Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-24T02:59:04Z

This pull request was exported from Phabricator. Differential Revision: D75919212

For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212) [ghstack-poisoned]

facebook-github-bot · 2025-06-24T04:21:20Z

This pull request was exported from Phabricator. Differential Revision: D75919212

@cccclai

This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11390 by @cccclai ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/22/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/22/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/21/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/22/orig @diff-train-skip-merge --------- Co-authored-by: Chen Lai <chenlai@fb.com> Co-authored-by: cccclai <chenlai@meta.com>

Pull Request resolved: pytorch/executorch#11390 For future needs without breacking API BC, in case we need to pass more information to the update API ghstack-source-id: 290059229 Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/)

@cccclai

This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11390 by @cccclai ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/22/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/22/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/21/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/22/orig @diff-train-skip-merge --------- Co-authored-by: Chen Lai <chenlai@fb.com> Co-authored-by: cccclai <chenlai@meta.com>

[2/N] Add update context
2f8c2b3
For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025

This was referenced Jun 5, 2025
[1/N] Add BackendOptions class #11389
Merged
[3/N] Add get_option/set_option function in backend interface #11391
Merged

facebook-github-bot added the fb-exported label Jun 5, 2025

Update on "[2/N] Add update context"
4f4dc6e
For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

This was referenced Jun 6, 2025
[4/N] Add backend options map #11462
Closed
[5/N] Add update in method #11463
Closed

Update on "[2/N] Add update context"
cb564f3
For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

This was referenced Jun 10, 2025
[6/N] Add update in module #11533
Closed
[7/N] Add sugar syntax for module.update #11534
Closed

Update on "[2/N] Add update context"
1884acf
For future needs without breacking API BC, in case we need to pass more information to the update API Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/) [ghstack-poisoned]

This was referenced Jun 17, 2025
Support Span to construct from a single element similar to ArrayRef #11757
Merged
[5/N] Add get_option/set_option APIs #11758
Closed

cccclai changed the title ~~[2/N] Add update context~~[2/N] Add option contextJun 18, 2025

kimishpatel reviewed Jun 23, 2025
View reviewed changes

kimishpatel approved these changes Jun 23, 2025
View reviewed changes

cccclai mentioned this pull request Jun 23, 2025
[5.1/ N] set_option/get_option API with {backend_name, backend options} only #11865
Merged

cccclai added 3 commits June 23, 2025 17:55

cccclai added 2 commits June 23, 2025 20:43

facebook-github-bot merged commit 8c02043 into gh/cccclai/22/baseJun 24, 2025

facebook-github-bot deleted the gh/cccclai/22/head branch June 24, 2025 07:59

facebook-github-bot temporarily deployed to cherry-pick-bot June 24, 2025 07:59 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jun 24, 2025
[2/N] Add option context #11875
Merged

cccclai added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Jun 24, 2025

Uh oh!

Conversation

cccclai commented Jun 5, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-botBot commented Jun 5, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11390

✅ No Failures

Uh oh!

facebook-github-bot commented Jun 5, 2025

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

facebook-github-bot commented Jun 18, 2025

Uh oh!

facebook-github-bot commented Jun 18, 2025

Uh oh!

facebook-github-bot commented Jun 23, 2025

Uh oh!

facebook-github-bot commented Jun 23, 2025

Uh oh!

kimishpatel left a comment

Choose a reason for hiding this comment

Uh oh!

cccclai commented Jun 23, 2025

Uh oh!

facebook-github-bot commented Jun 23, 2025

Uh oh!

facebook-github-bot commented Jun 23, 2025

Uh oh!

facebook-github-bot commented Jun 24, 2025

Uh oh!

facebook-github-bot commented Jun 24, 2025

Uh oh!

facebook-github-bot commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cccclai commented Jun 5, 2025•
edited
Loading

pytorch-botBot commented Jun 5, 2025•
edited
Loading