Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707

Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom
Tanish2101:implement-sharedptr-loader
Closed

Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom
Tanish2101:implement-sharedptr-loader

Conversation

@Tanish2101

@Tanish2101Tanish2101 commented Jun 15, 2025

Copy link
Copy Markdown

Summary:
Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).

Fixes
Fixes#11562

Test plan:
Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():

  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).

@pytorch-bot

pytorch-botBot commented Jun 15, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures, 1 Unrelated Failure

As of commit 5b4770d with merge base ef79c3e (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot

facebook-github-bot commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

Hi @Tanish2101!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Tanish2101

Tanish2101 commented Jun 15, 2025

Copy link
Copy Markdown
Author

@pytorchbot label "release notes: none"

@pytorch-botpytorch-botBot added the release notes: none Do not include this in the release notes label Jun 15, 2025
@Tanish2101Tanish2101 reopened this Jun 15, 2025
@Tanish2101

Tanish2101 commented Jun 15, 2025

Copy link
Copy Markdown
Author

Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2025
@facebook-github-bot

facebook-github-bot commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mergennachin

mergennachin commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Hi @Tanish2101

Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)

@Tanish2101

Tanish2101 commented Jun 16, 2025

Copy link
Copy Markdown
Author

I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?

@mergennachin

@Tanish2101

Tanish2101 commented Jun 16, 2025

Copy link
Copy Markdown
Author

So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin

JacobSzwejbka
JacobSzwejbka requested changes Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h Outdated
return size_;
}

ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(

@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?

@Tanish2101Tanish2101Jun 17, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.

@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka approved these changes Jun 26, 2025
View reviewed changes

@JacobSzwejbkaJacobSzwejbka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!

@JacobSzwejbka

JacobSzwejbka commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

All of the failures looked like infra issues so rerunning the jobs

JacobSzwejbkaand others added 3 commits June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101

Tanish2101 commented Jun 28, 2025

Copy link
Copy Markdown
Author

Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum

@JacobSzwejbka

@github-actions

github-actionsBot commented Sep 2, 2025

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actionsgithub-actionsBot added the Stale PRs inactive for over 60 days label Sep 2, 2025
@github-actions

github-actionsBot commented Nov 1, 2025

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@lucylq

lucylq commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?

@github-actions

github-actionsBot commented Feb 22, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@kirklandsign

kirklandsign commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Hi @Tanish2101 mind updating the branch?

@98yearsoldshark98yearsoldshark mentioned this pull request Aug 17, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees

No one assigned

Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader

7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707
Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Closed
Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Conversation
@Tanish2101
@Tanish2101Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Summary:

Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).
Fixes
Fixes#11562
Test plan:

Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():
  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).
@pytorch-bot
pytorch-botBot
commented
Jun 15, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707
Note: Links to docs will display an error until the docs builds have been completed.
❌ 17 New Failures, 1 Unrelated Failure
As of commit 5b4770d with merge base ef79c3e (image):
NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
@pytorchbot label "release notes: none"
@pytorch-botpytorch-botBot
added
the 
release notes: none
Do not include this in the release notes
label
Jun 15, 2025
@Tanish2101Tanish2101
reopened this
Jun 15, 2025
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 15, 2025
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@mergennachin
mergennachin
commented
Jun 16, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101
Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?
@mergennachin
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin
JacobSzwejbka
JacobSzwejbka
requested changes
Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h
Outdated

 return size_;
 }

 ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?
@Tanish2101Tanish2101Jun 17, 2025

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.
@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka
approved these changes
Jun 26, 2025
View reviewed changes
@JacobSzwejbkaJacobSzwejbka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!
@JacobSzwejbka
JacobSzwejbka
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
All of the failures looked like infra issues so rerunning the jobs
JacobSzwejbkaand others
added 3 commits
June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101
Tanish2101
commented
Jun 28, 2025

Copy link


Copy Markdown

Author
Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum
@JacobSzwejbka
@github-actions
github-actionsBot
commented
Sep 2, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@github-actionsgithub-actionsBot
added
the 
Stale
PRs inactive for over 60 days
label
Sep 2, 2025
@github-actions
github-actionsBot
commented
Nov 1, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@lucylq
lucylq
commented
Nov 4, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?
@github-actions
github-actionsBot
commented
Feb 22, 2026

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@kirklandsign
kirklandsign
commented
Mar 16, 2026

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 mind updating the branch?
@98yearsoldshark98yearsoldshark
mentioned this pull request
Aug 17, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader


7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707
Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Closed
Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Conversation
@Tanish2101
@Tanish2101Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Summary:

Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).
Fixes
Fixes#11562
Test plan:

Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():
  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).
@pytorch-bot
pytorch-botBot
commented
Jun 15, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707
Note: Links to docs will display an error until the docs builds have been completed.
❌ 17 New Failures, 1 Unrelated Failure
As of commit 5b4770d with merge base ef79c3e (image):
NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
@pytorchbot label "release notes: none"
@pytorch-botpytorch-botBot
added
the 
release notes: none
Do not include this in the release notes
label
Jun 15, 2025
@Tanish2101Tanish2101
reopened this
Jun 15, 2025
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 15, 2025
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@mergennachin
mergennachin
commented
Jun 16, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101
Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?
@mergennachin
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin
JacobSzwejbka
JacobSzwejbka
requested changes
Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h
Outdated

 return size_;
 }

 ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?
@Tanish2101Tanish2101Jun 17, 2025

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.
@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka
approved these changes
Jun 26, 2025
View reviewed changes
@JacobSzwejbkaJacobSzwejbka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!
@JacobSzwejbka
JacobSzwejbka
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
All of the failures looked like infra issues so rerunning the jobs
JacobSzwejbkaand others
added 3 commits
June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101
Tanish2101
commented
Jun 28, 2025

Copy link


Copy Markdown

Author
Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum
@JacobSzwejbka
@github-actions
github-actionsBot
commented
Sep 2, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@github-actionsgithub-actionsBot
added
the 
Stale
PRs inactive for over 60 days
label
Sep 2, 2025
@github-actions
github-actionsBot
commented
Nov 1, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@lucylq
lucylq
commented
Nov 4, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?
@github-actions
github-actionsBot
commented
Feb 22, 2026

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@kirklandsign
kirklandsign
commented
Mar 16, 2026

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 mind updating the branch?
@98yearsoldshark98yearsoldshark
mentioned this pull request
Aug 17, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader


7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707
Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Closed
Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Conversation
@Tanish2101
@Tanish2101Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Summary:

Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).
Fixes
Fixes#11562
Test plan:

Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():
  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).
@pytorch-bot
pytorch-botBot
commented
Jun 15, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707
Note: Links to docs will display an error until the docs builds have been completed.
❌ 17 New Failures, 1 Unrelated Failure
As of commit 5b4770d with merge base ef79c3e (image):
NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
@pytorchbot label "release notes: none"
@pytorch-botpytorch-botBot
added
the 
release notes: none
Do not include this in the release notes
label
Jun 15, 2025
@Tanish2101Tanish2101
reopened this
Jun 15, 2025
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 15, 2025
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@mergennachin
mergennachin
commented
Jun 16, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101
Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?
@mergennachin
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin
JacobSzwejbka
JacobSzwejbka
requested changes
Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h
Outdated

 return size_;
 }

 ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?
@Tanish2101Tanish2101Jun 17, 2025

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.
@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka
approved these changes
Jun 26, 2025
View reviewed changes
@JacobSzwejbkaJacobSzwejbka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!
@JacobSzwejbka
JacobSzwejbka
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
All of the failures looked like infra issues so rerunning the jobs
JacobSzwejbkaand others
added 3 commits
June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101
Tanish2101
commented
Jun 28, 2025

Copy link


Copy Markdown

Author
Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum
@JacobSzwejbka
@github-actions
github-actionsBot
commented
Sep 2, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@github-actionsgithub-actionsBot
added
the 
Stale
PRs inactive for over 60 days
label
Sep 2, 2025
@github-actions
github-actionsBot
commented
Nov 1, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@lucylq
lucylq
commented
Nov 4, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?
@github-actions
github-actionsBot
commented
Feb 22, 2026

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@kirklandsign
kirklandsign
commented
Mar 16, 2026

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 mind updating the branch?
@98yearsoldshark98yearsoldshark
mentioned this pull request
Aug 17, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader


7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707
Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Closed
Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Conversation
@Tanish2101
@Tanish2101Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Summary:

Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).
Fixes
Fixes#11562
Test plan:

Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():
  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).
@pytorch-bot
pytorch-botBot
commented
Jun 15, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707
Note: Links to docs will display an error until the docs builds have been completed.
❌ 17 New Failures, 1 Unrelated Failure
As of commit 5b4770d with merge base ef79c3e (image):
NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
@pytorchbot label "release notes: none"
@pytorch-botpytorch-botBot
added
the 
release notes: none
Do not include this in the release notes
label
Jun 15, 2025
@Tanish2101Tanish2101
reopened this
Jun 15, 2025
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 15, 2025
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@mergennachin
mergennachin
commented
Jun 16, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101
Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?
@mergennachin
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin
JacobSzwejbka
JacobSzwejbka
requested changes
Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h
Outdated

 return size_;
 }

 ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?
@Tanish2101Tanish2101Jun 17, 2025

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.
@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka
approved these changes
Jun 26, 2025
View reviewed changes
@JacobSzwejbkaJacobSzwejbka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!
@JacobSzwejbka
JacobSzwejbka
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
All of the failures looked like infra issues so rerunning the jobs
JacobSzwejbkaand others
added 3 commits
June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101
Tanish2101
commented
Jun 28, 2025

Copy link


Copy Markdown

Author
Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum
@JacobSzwejbka
@github-actions
github-actionsBot
commented
Sep 2, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@github-actionsgithub-actionsBot
added
the 
Stale
PRs inactive for over 60 days
label
Sep 2, 2025
@github-actions
github-actionsBot
commented
Nov 1, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@lucylq
lucylq
commented
Nov 4, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?
@github-actions
github-actionsBot
commented
Feb 22, 2026

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@kirklandsign
kirklandsign
commented
Mar 16, 2026

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 mind updating the branch?
@98yearsoldshark98yearsoldshark
mentioned this pull request
Aug 17, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader


7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707
Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Closed
Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Conversation
@Tanish2101
@Tanish2101Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Summary:

Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).
Fixes
Fixes#11562
Test plan:

Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():
  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).
@pytorch-bot
pytorch-botBot
commented
Jun 15, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707
Note: Links to docs will display an error until the docs builds have been completed.
❌ 17 New Failures, 1 Unrelated Failure
As of commit 5b4770d with merge base ef79c3e (image):
NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
@pytorchbot label "release notes: none"
@pytorch-botpytorch-botBot
added
the 
release notes: none
Do not include this in the release notes
label
Jun 15, 2025
@Tanish2101Tanish2101
reopened this
Jun 15, 2025
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 15, 2025
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@mergennachin
mergennachin
commented
Jun 16, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101
Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?
@mergennachin
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin
JacobSzwejbka
JacobSzwejbka
requested changes
Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h
Outdated

 return size_;
 }

 ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?
@Tanish2101Tanish2101Jun 17, 2025

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.
@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka
approved these changes
Jun 26, 2025
View reviewed changes
@JacobSzwejbkaJacobSzwejbka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!
@JacobSzwejbka
JacobSzwejbka
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
All of the failures looked like infra issues so rerunning the jobs
JacobSzwejbkaand others
added 3 commits
June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101
Tanish2101
commented
Jun 28, 2025

Copy link


Copy Markdown

Author
Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum
@JacobSzwejbka
@github-actions
github-actionsBot
commented
Sep 2, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@github-actionsgithub-actionsBot
added
the 
Stale
PRs inactive for over 60 days
label
Sep 2, 2025
@github-actions
github-actionsBot
commented
Nov 1, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@lucylq
lucylq
commented
Nov 4, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?
@github-actions
github-actionsBot
commented
Feb 22, 2026

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@kirklandsign
kirklandsign
commented
Mar 16, 2026

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 mind updating the branch?
@98yearsoldshark98yearsoldshark
mentioned this pull request
Aug 17, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader


7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707
Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Closed
Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Conversation
@Tanish2101
@Tanish2101Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Summary:

Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).
Fixes
Fixes#11562
Test plan:

Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():
  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).
@pytorch-bot
pytorch-botBot
commented
Jun 15, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707
Note: Links to docs will display an error until the docs builds have been completed.
❌ 17 New Failures, 1 Unrelated Failure
As of commit 5b4770d with merge base ef79c3e (image):
NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
@pytorchbot label "release notes: none"
@pytorch-botpytorch-botBot
added
the 
release notes: none
Do not include this in the release notes
label
Jun 15, 2025
@Tanish2101Tanish2101
reopened this
Jun 15, 2025
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 15, 2025
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@mergennachin
mergennachin
commented
Jun 16, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101
Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?
@mergennachin
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin
JacobSzwejbka
JacobSzwejbka
requested changes
Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h
Outdated

 return size_;
 }

 ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?
@Tanish2101Tanish2101Jun 17, 2025

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.
@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka
approved these changes
Jun 26, 2025
View reviewed changes
@JacobSzwejbkaJacobSzwejbka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!
@JacobSzwejbka
JacobSzwejbka
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
All of the failures looked like infra issues so rerunning the jobs
JacobSzwejbkaand others
added 3 commits
June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101
Tanish2101
commented
Jun 28, 2025

Copy link


Copy Markdown

Author
Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum
@JacobSzwejbka
@github-actions
github-actionsBot
commented
Sep 2, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@github-actionsgithub-actionsBot
added
the 
Stale
PRs inactive for over 60 days
label
Sep 2, 2025
@github-actions
github-actionsBot
commented
Nov 1, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@lucylq
lucylq
commented
Nov 4, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?
@github-actions
github-actionsBot
commented
Feb 22, 2026

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@kirklandsign
kirklandsign
commented
Mar 16, 2026

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 mind updating the branch?
@98yearsoldshark98yearsoldshark
mentioned this pull request
Aug 17, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader


7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Implement load_into for SharedPtrDataLoader and add test (#11562) - #11707
Closed
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Closed
Implement load_into for SharedPtrDataLoader and add test (#11562)#11707
Tanish2101 wants to merge 7 commits into
pytorch:mainfrom 
Tanish2101:implement-sharedptr-loader
Conversation
@Tanish2101
@Tanish2101Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Summary:

Implemented the load_into method for SharedPtrDataLoader to support copying preallocated buffer data into a target buffer. This enables use cases where mutable model state has a meaningful initial value (e.g., on-device training or serialized read-before-write data).
Fixes
Fixes#11562
Test plan:

Added a unit test in shared_ptr_data_loader_test.cpp to verify that load_into():
  1. Copies the correct data for valid offset/size.
  2. Fails properly on invalid requests (e.g., out-of-bounds reads).
@pytorch-bot
pytorch-botBot
commented
Jun 15, 2025•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11707
Note: Links to docs will display an error until the docs builds have been completed.
❌ 17 New Failures, 1 Unrelated Failure
As of commit 5b4770d with merge base ef79c3e (image):
NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
@pytorchbot label "release notes: none"
@pytorch-botpytorch-botBot
added
the 
release notes: none
Do not include this in the release notes
label
Jun 15, 2025
@Tanish2101Tanish2101
reopened this
Jun 15, 2025
@Tanish2101
Tanish2101
commented
Jun 15, 2025

Copy link


Copy Markdown

Author
Hi @JacobSzwejbka, I created a PR for this issue. This is the first time I am contributing to executorch. Please Let me know if there are any changes required.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 15, 2025
@facebook-github-bot
facebook-github-bot
commented
Jun 15, 2025

Copy link


Copy Markdown

Contributor
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@mergennachin
mergennachin
commented
Jun 16, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101
Thank you for the contribution. Looks like @keyprocedure has started the PR for the same task (#11654)
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
I have implemented the load_into() function for shared_ptr data loader so the implementation done by @keyprocedure for mmap data loader is sufficient? means there is no need for seperate implementation for shared_ptr ?
@mergennachin
@Tanish2101
Tanish2101
commented
Jun 16, 2025

Copy link


Copy Markdown

Author
So now what should I do? means should I close the pull request which I have created for this issue? Let me know @mergennachin
JacobSzwejbka
JacobSzwejbka
requested changes
Jun 16, 2025
View reviewed changes
Comment threadextension/data_loader/shared_ptr_data_loader.h
Outdated

 return size_;
 }

 ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
@JacobSzwejbkaJacobSzwejbkaJun 16, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the declaration and implementation?
@Tanish2101Tanish2101Jun 17, 2025

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged the 'load_into' function declaration and implemention as suggested by you, please review it.
@Tanish2101
Updated the shared_ptr_data_loader.h
cb04035
I have merge the declaration and implementation of 'load_into' function.
JacobSzwejbka
JacobSzwejbka
approved these changes
Jun 26, 2025
View reviewed changes
@JacobSzwejbkaJacobSzwejbka
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Letting CI run, but looks good. Thanks for contributing!
@JacobSzwejbka
JacobSzwejbka
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
All of the failures looked like infra issues so rerunning the jobs
JacobSzwejbkaand others
added 3 commits
June 27, 2025 14:01
@JacobSzwejbka
Merge branch 'main' into implement-sharedptr-loader
bea66ff
@Tanish2101
Merge branch 'pytorch:main' into implement-sharedptr-loader
73fdc6d
@Tanish2101
Fix: Use valid Error enum in SharedPtrDataLoader and update test
2c3eee1
- Replaced non-existent with in implementation.
- Updated the corresponding unit test to match the corrected error.
- Ensures correctness and prevents enum resolution error during compilation.
@Tanish2101
Tanish2101
commented
Jun 28, 2025

Copy link


Copy Markdown

Author
Fixed: Changed invalid error code Error::OutOfBounds to Error::InvalidArgument in both implementation and test. OutOfBounds is not part of the executorch::runtime::Error enum
@JacobSzwejbka
@github-actions
github-actionsBot
commented
Sep 2, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@github-actionsgithub-actionsBot
added
the 
Stale
PRs inactive for over 60 days
label
Sep 2, 2025
@github-actions
github-actionsBot
commented
Nov 1, 2025

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@lucylq
lucylq
commented
Nov 4, 2025

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 , are you still working on this? See that it's approved, do you want to rebase and merge?
@github-actions
github-actionsBot
commented
Feb 22, 2026

Copy link


Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale. 
Feel free to remove the Stale label if you feel this was a mistake. 
If you are unable to remove the Stale label please contact a maintainer in order to do so. 
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.
@kirklandsign
kirklandsign
commented
Mar 16, 2026

Copy link


Copy Markdown

Contributor
Hi @Tanish2101 mind updating the branch?
@98yearsoldshark98yearsoldshark
mentioned this pull request
Aug 17, 2026

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@JacobSzwejbkaJacobSzwejbkaJacobSzwejbka approved these changes
@lucylqlucylqAwaiting requested review from lucylq

Assignees


No one assigned


Labels

ciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Implement load_into for the shared_ptr data loader


7 participants

@Tanish2101@facebook-github-bot@mergennachin@JacobSzwejbka@lucylq@kirklandsign@nil-is-all