Skip to content

Fix shadowing error in mmap_data_loader.cpp#11858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregoryComer merged 1 commit into from
Jun 23, 2025
Merged

Fix shadowing error in mmap_data_loader.cpp #11858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extension/data_loader/mmap_data_loader.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -181,9 +181,9 @@ Result<FreeableBuffer> MmapDataLoader::load(
size_t size,
ET_UNUSED const DataLoader::SegmentInfo& segment_info) const {
// Ensure read range is valid.
auto err = validate_input(offset, size);
if (err != Error::Ok) {
return err;
auto validation_err = validate_input(offset, size);
if (validation_err != Error::Ok) {
return validation_err;
}

// mmap() will fail if the size is zero.
Expand Down