Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Build XNNPACK as an ExternalProject - #12425

Closed
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head
Closed

Build XNNPACK as an ExternalProject#12425
swolchok wants to merge 14 commits into
mainfrom
gh/swolchok/505/head

Conversation

@swolchok

Copy link
Copy Markdown
Contributor

I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)

[ghstack-poisoned]
@swolchok

swolchok commented Jul 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Jul 13, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12425

Note: Links to docs will display an error until the docs builds have been completed.

❌ 114 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 466f669 with merge base b9bb3c1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 6ce92d7
ghstack-comment-id: 3067161235
Pull-Request: #12425
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2025
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 13, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: 0aa08b8
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok added the release notes: none Do not include this in the release notes label Jul 14, 2025
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apple build is failing because it can't find libXNNPACK.a: https://github.com/pytorch/executorch/actions/runs/16251337270/job/45881437516?pr=12425#step:9:47386

android build is failing because I didn't propagate cross compilation settings to the ExternalProject: https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881440178?pr=12425#step:15:16927

llama runner linux build is failing because CMake is passing -lXNNPACK instead of the path to the static lib. (this happened during debugging before and it was because the XNNPACK target wasn't defined; probably the same again?) https://github.com/pytorch/executorch/actions/runs/16251337288/job/45881439862?pr=12425

unittest failures don't look related but we'll want to keep an eye on them.

@swolchok

Copy link
Copy Markdown
ContributorAuthor

I want to see EXPORT work locally before I come back and fix broader platform support, so I'm going to do that first. Converting to draft in the meantime.

@swolchok
swolchok marked this pull request as draft July 14, 2025 15:35
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

build_frameworks_ios error:

2025-07-15T00:24:13.6245540Z Merging libraries:
2025-07-15T00:24:13.6245660Z libXNNPACK.a
2025-07-15T00:24:13.6245770Z libxnnpack_backend.a
2025-07-15T00:24:13.6245920Z libxnnpack-microkernels-prod.a
2025-07-15T00:24:13.6246060Z from ios/Release
2025-07-15T00:24:13.6246360Z into library /Users/runner/work/executorch/executorch/pytorch/executorch/cmake-out/libbackend_xnnpack_ios.a
2025-07-15T00:24:13.6246770Z File ios/Release/libXNNPACK.a does not exist

Base automatically changed from gh/swolchok/508/head to mainJuly 15, 2025 16:41
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 2286359
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok
swolchok changed the base branch from main to gh/swolchok/510/headJuly 15, 2025 18:19
swolchok added a commit that referenced this pull request Jul 15, 2025
As with the previous PR #12425, I think this is needed to get EXPORT
to work.
ghstack-source-id: 0f66acd
ghstack-comment-id: 3071359023
Pull-Request: #12468
@swolchok

Copy link
Copy Markdown
ContributorAuthor

test-llava-runner-linux failure looks like a flake: https://github.com/pytorch/executorch/actions/runs/16301129189/job/46035741014?pr=12425#step:15:15293 . therefore publishing for review

@swolchok
swolchok marked this pull request as ready for review July 15, 2025 19:58

@mcr229mcr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the XNNPACK cmake/dependencies.cmake look good to me

set(xnnpack_third_party pthreadpool extension_threadpool cpuinfo)

include(cmake/Dependencies.cmake)
set(xnnpack_third_party XNNPACK pthreadpool extension_threadpool cpuinfo)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what does this rearrangment do?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found it weird that we were mutating xnnpack_third_party in cmake/Dependencies.cmake rather than setting it all at once

Comment on lines +74 to +75
set_target_properties(
XNNPACK PROPERTIES INTERFACE_LINK_LIBRARIES xnnpack-microkernels-prod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot does this mean that any targets that link XNNPACK will also automatically link xnnpack-microkernels-prod as well? So we don't have to explicitly list both XNNPACK and xnnpack-microkernels-prod? I was trying to figure out how to do this for a while, but never figured it out.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target_link_libraries with visibility PUBLIC or INTERFACE does this for normal libraries, but you need to do it this way for IMPORTED libraries.

LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
add_library(kleidiai SHARED IMPORTED)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i merged something that might have conflict here. I just added a check

if (TARGET kleidiai)

before adding the library

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think

swolchok added a commit that referenced this pull request Jul 15, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
Base automatically changed from gh/swolchok/510/head to mainJuly 15, 2025 20:44
[ghstack-poisoned]
@swolchok

Copy link
Copy Markdown
ContributorAuthor

bunch of flakes that need to be rerun to make sure but no actual problems in the 7 failures so far

lucylq pushed a commit that referenced this pull request Jul 17, 2025
Following PR (#12425) broke Linux manywheel and there was no way to
repro it on that PR; I just happened to catch it because the PR after
that (#12468) triggered the manywheel build.
@swolchok

Copy link
Copy Markdown
ContributorAuthor

Apparently FetchContent is preferred over ExternalProject. The thing I wanted from ExternalProject is separating our build from the dependency's build (i.e., not using add_subdirectory), because the XNNPACK dependency ecosystem doesn't support EXPORT. IIUC, we can get that separation using FetchContent by configuring it to support find_package (using either FIND_PACKAGE_ARGS when we don't require specific changes to or a bleeding-edge version of the dependency, or OVERRIDE_FIND_PACKAGE when we do have such a requirement; both will result in later find_package calls hitting the FetchContent version of the dep, it's just that FIND_PACKAGE_ARGS might find the thing installed system-wide) and then using find_package.

[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 18, 2025
I believe this is necessary to support EXPORT. (We probably should not
land this unless we have a PR stacked on top of this that successfully
converts the build to EXPORT; sending this out so I can get CI going)
ghstack-source-id: d179497
ghstack-comment-id: 3067161235
Pull-Request: #12425
@swolchokswolchok closed this Sep 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binariesciflow/trunkCLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@mcr229@facebook-github-bot