Skip to content

Delete tools/cmake/{buck_util,resolve_buck}.py - #13588

Closed
swolchok wants to merge 2 commits into
gh/swolchok/556/headfrom
gh/swolchok/558/head
Closed

Delete tools/cmake/{buck_util,resolve_buck}.py#13588
swolchok wants to merge 2 commits into
gh/swolchok/556/headfrom
gh/swolchok/558/head

Conversation

@swolchok

@swolchokswolchok commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

We don't need resolve_buck.py in check_for_installed_private_headers_in_cmake_out, so we can just delete it.

[ghstack-poisoned]
@swolchok

swolchok commented Aug 21, 2025

Copy link
Copy Markdown
ContributorAuthor

@pytorch-bot

pytorch-botBot commented Aug 21, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13588

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 93e0042 with merge base 335de46 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025
swolchok added a commit that referenced this pull request Aug 21, 2025
…_private_headers_in_cmake_out?
ghstack-source-id: dd3824e
ghstack-comment-id: 3211876811
Pull-Request: #13588
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Aug 21, 2025
ghstack-source-id: e9bcbf3
ghstack-comment-id: 3211876811
Pull-Request: #13588
@swolchokswolchok changed the title DRAFT: Does CI need resolve_buck.py to be used in check_for_installed_private_headers_in_cmake_out?Delete tools/cmake/{buck_util,resolve_buck}.pyAug 21, 2025
@swolchokswolchok added the release notes: none Do not include this in the release notes label Aug 21, 2025
@swolchok
swolchok marked this pull request as ready for review August 21, 2025 22:27
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actionsgithub-actionsBot added the Stale PRs inactive for over 60 days label Oct 21, 2025
@meta-cla

meta-claBot commented Nov 18, 2025

Copy link
Copy Markdown

Hi @swolchok!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

1 similar comment
@github-actions

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@swolchok